Updates including source referencing.

Oren (electricessence) · Oren (electricessence) · commit 774754e2e809 · 2020-07-11T10:47:41.000-07:00
diff --git a/AsyncDisposeHandler.cs b/AsyncDisposeHandler.cs
@@ -32,7 +32,7 @@ public AsyncDisposeHandler(T value, Func<ValueTask> action) : base(action)
 
 		protected override ValueTask OnDisposeAsync()
 		{
-			Value = default;
+			Value = default!;
 			return base.OnDisposeAsync();
 		}
 	}
diff --git a/DeferredCleanupBase.cs b/DeferredCleanupBase.cs
@@ -50,12 +50,12 @@ public bool IsRunning
 		}
 
 		private readonly object _timerSync = new object();
-		private Timer _cleanupTimer;
+		private Timer? _cleanupTimer;
 
 
 		protected void ResetTimer()
 		{
-			Timer ct2;
+			Timer? ct2;
 			lock (_timerSync)
 			{
 				ct2 = Interlocked.Exchange(ref _cleanupTimer, null);
@@ -138,7 +138,7 @@ public void ClearCleanup()
 			}
 		}
 
-		private void Cleanup(object state = null)
+		private void Cleanup(object? state = null)
 		{
 			if (WasDisposed)
 				return; // If another thread enters here after disposal don't allow.
diff --git a/DisposableStateBase.cs b/DisposableStateBase.cs
@@ -56,7 +56,7 @@ protected bool AssertIsAlive(bool strict = false)
 		#region Before Disposal
 		protected virtual void OnBeforeDispose() { }
 
-		private event EventHandler BeforeDisposeInternal;
+		private event EventHandler? BeforeDisposeInternal;
 		/// <summary>
 		/// BeforeDispose will be triggered once right before disposal commences.
 		/// </summary>
@@ -129,15 +129,15 @@ protected static TNullable Nullify<TNullable>(ref TNullable x)
 			where TNullable : class
 		{
 			var y = x;
-			x = null;
+			x = default!;
 			return y;
 		}
 
 		protected static void DisposeOf<T>(ref T x)
 			where T : class, IDisposable
 		{
 			var y = x;
-			x = null;
+			x = default!;
 			y?.Dispose();
 		}
 
diff --git a/DisposeHandler.cs b/DisposeHandler.cs
@@ -32,7 +32,7 @@ public DisposeHandler(T value, Action action) : base(action)
 
 		protected override void OnDispose()
 		{
-			Value = default;
+			Value = default!;
 			base.OnDispose();
 		}
 	}
diff --git a/LICENSE.md b/LICENSE.md
diff --git a/Open.Disposable.csproj b/Open.Disposable.csproj
@@ -2,28 +2,31 @@
 
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
-    <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
-    <Description>
-      Provides a set of useful classes when implementing a disposable or dealing with disposables.
-
-      Part of the "Open" set of libraries.
-    </Description>
-    <Authors>electricessence</Authors>
-    <Company />
-    <Product />
+		<Nullable>enable</Nullable>
+		<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
+		<Authors>electricessence</Authors>
+		<Description>Provides a set of useful classes when implementing a disposable or dealing with disposables.
+
+Part of the "Open" set of libraries.
+</Description>
     <PackageTags>dotnet, dotnetcore, cs, idisposable, disposablebase, disposable-pattern, extensions, threadsafe, thread-safe</PackageTags>
-    <Copyright>https://github.com/electricessence/Open.Disposable/blob/master/LISCENSE.md</Copyright>
-    <PackageIconUrl></PackageIconUrl>
-    <PackageProjectUrl>https://github.com/electricessence/Open.Disposable/</PackageProjectUrl>
-    <RepositoryUrl>https://github.com/electricessence/Open.Disposable/</RepositoryUrl>
+    <Copyright>https://github.com/Open-NET-Libraries/Open.Disposable/blob/master/LICENSE.md</Copyright>
+    <PackageProjectUrl>https://github.com/Open-NET-Libraries/Open.Disposable/</PackageProjectUrl>
+    <RepositoryUrl>https://github.com/Open-NET-Libraries/Open.Disposable/</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
-    <Version>2.3.0</Version>
+    <Version>2.3.2</Version>
     <PackageReleaseNotes></PackageReleaseNotes>
-    <AssemblyVersion>2.3.0.0</AssemblyVersion>
-    <FileVersion>2.3.0.0</FileVersion>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
+		<PublishRepositoryUrl>true</PublishRepositoryUrl>
+		<IncludeSymbols>true</IncludeSymbols>
+		<SymbolPackageFormat>snupkg</SymbolPackageFormat>
+		<PackageIcon>logo.png</PackageIcon>
   </PropertyGroup>
-
+	
+	<ItemGroup>
+		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
+	</ItemGroup>
+	
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
     <LangVersion>latest</LangVersion>
   </PropertyGroup>
@@ -36,7 +39,11 @@
     <None Remove=".git" />
     <None Remove=".gitignore" />
     <None Remove="LISCENSE.md" />
-    <None Remove="README.md" />
+    <None Remove="README.md"/>
+    <None Include="logo.png">
+      <Pack>True</Pack>
+      <PackagePath></PackagePath>
+    </None>
   </ItemGroup>
 
   <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
diff --git a/logo.png b/logo.png

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public AsyncDisposeHandler(T value, Func<ValueTask> action) : base(action)`
`32`	`32`
`33`	`33`	`protected override ValueTask OnDisposeAsync()`
`34`	`34`	`{`
`35`		`- Value = default;`
	`35`	`+ Value = default!;`
`36`	`36`	`return base.OnDisposeAsync();`
`37`	`37`	`}`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,12 +50,12 @@ public bool IsRunning`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`private readonly object _timerSync = new object();`
`53`		`- private Timer _cleanupTimer;`
	`53`	`+ private Timer? _cleanupTimer;`
`54`	`54`
`55`	`55`
`56`	`56`	`protected void ResetTimer()`
`57`	`57`	`{`
`58`		`- Timer ct2;`
	`58`	`+ Timer? ct2;`
`59`	`59`	`lock (_timerSync)`
`60`	`60`	`{`
`61`	`61`	`ct2 = Interlocked.Exchange(ref _cleanupTimer, null);`
`@@ -138,7 +138,7 @@ public void ClearCleanup()`
`138`	`138`	`}`
`139`	`139`	`}`
`140`	`140`
`141`		`- private void Cleanup(object state = null)`
	`141`	`+ private void Cleanup(object? state = null)`
`142`	`142`	`{`
`143`	`143`	`if (WasDisposed)`
`144`	`144`	`return; // If another thread enters here after disposal don't allow.`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ protected bool AssertIsAlive(bool strict = false)`
`56`	`56`	`#region Before Disposal`
`57`	`57`	`protected virtual void OnBeforeDispose() { }`
`58`	`58`
`59`		`- private event EventHandler BeforeDisposeInternal;`
	`59`	`+ private event EventHandler? BeforeDisposeInternal;`
`60`	`60`	`/// <summary>`
`61`	`61`	`/// BeforeDispose will be triggered once right before disposal commences.`
`62`	`62`	`/// </summary>`
`@@ -129,15 +129,15 @@ protected static TNullable Nullify<TNullable>(ref TNullable x)`
`129`	`129`	`where TNullable : class`
`130`	`130`	`{`
`131`	`131`	`var y = x;`
`132`		`- x = null;`
	`132`	`+ x = default!;`
`133`	`133`	`return y;`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`protected static void DisposeOf<T>(ref T x)`
`137`	`137`	`where T : class, IDisposable`
`138`	`138`	`{`
`139`	`139`	`var y = x;`
`140`		`- x = null;`
	`140`	`+ x = default!;`
`141`	`141`	`y?.Dispose();`
`142`	`142`	`}`
`143`	`143`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public DisposeHandler(T value, Action action) : base(action)`
`32`	`32`
`33`	`33`	`protected override void OnDispose()`
`34`	`34`	`{`
`35`		`- Value = default;`
	`35`	`+ Value = default!;`
`36`	`36`	`base.OnDispose();`
`37`	`37`	`}`
`38`	`38`	`}`