Cleanup and simplification.

Author: electricessence

AsyncProcess.cs

@@ -1,15 +1,11 @@
 using Open.Disposable;
 using System;
-using System.Diagnostics.CodeAnalysis;
 using System.Diagnostics.Contracts;
 using System.Threading;
 using System.Threading.Tasks;
 
 namespace Open.Threading
 {
-	[SuppressMessage("ReSharper", "MemberCanBeProtected.Global")]
-	[SuppressMessage("ReSharper", "VirtualMemberNeverOverridden.Global")]
-	[SuppressMessage("ReSharper", "UnusedAutoPropertyAccessor.Global")]
 	public class AsyncProcess<T> : DisposableBase
 		where T : new()
 	{
@@ -25,7 +21,7 @@ public AsyncProcess(Action<T> closure, TaskScheduler? scheduler = null)
 			Closure = closure ?? throw new ArgumentNullException(nameof(closure));
 		}
 
-		protected ReaderWriterLockSlim? SyncLock = new ReaderWriterLockSlim();
+		protected ReaderWriterLockSlim? SyncLock = new();
 
 		protected TaskScheduler? Scheduler
 		{
@@ -158,7 +154,7 @@ public class AsyncProcess : AsyncProcess<Progress>
 	{
 		protected AsyncProcess(TaskScheduler? scheduler) : base(scheduler)
 		{
-			
+
 		}
 
 		// ReSharper disable once MemberCanBeProtected.Global

AsyncQuery.cs

@@ -44,7 +44,7 @@ protected Task<TResult> EnsureProcessValued(bool once, TimeSpan? timeAllowedBefo
 				}, () =>
 				{
 
-					task = new Task<TResult>(Process, new Progress());
+					task = new Task<TResult>(Process!, new Progress());
 					task.Start(Scheduler);
 					InternalTask = InternalTaskValued = task;
 					Count++;

Container.cs

@@ -9,8 +9,6 @@ namespace Open.Threading
 	public delegate void ValueInitialzedEventHandler<in T>(object source, T initValue);
 	public delegate void ValueUpdatedEventHandler<in T>(object source, T originalValue, T newValue);
 
-
-	[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 	public interface IContainValue<out T>
 	{
 		/// <summary>
@@ -38,7 +36,6 @@ public interface IContainValue<out T>
 	/// Interface for acting as a 'container' for values.  Similar to Nullable but as an interface.
 	/// </summary>
 	/// <typeparam name="T">The type to be contained.</typeparam>
-	[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 	// ReSharper disable once InheritdocConsiderUsage
 	public interface IContainer<T> : IContainValue<T>, IDisposable, IDisposalState // To ensure manual cleanup is implmented.
 	{
@@ -63,8 +60,6 @@ public interface IContainer<T> : IContainValue<T>, IDisposable, IDisposalState /
 	/// </summary>
 	/// <typeparam name="T">The type to be contained.</typeparam>
 	// ReSharper disable once InheritdocConsiderUsage
-	[SuppressMessage("ReSharper", "VirtualMemberNeverOverridden.Global")]
-	[SuppressMessage("ReSharper", "UnusedParameter.Global")]
 	public abstract class ContainerBase<T> : DisposableBase, IContainer<T>
 	{
 		protected readonly ReaderWriterLockSlim SyncLock;
@@ -237,7 +232,6 @@ protected override void OnDispose()
 	/// This class is the same as ContainerLight&lt;TLock&gt; but never throws away it's scheduler and can be re-rendered at anytime.
 	/// </summary>
 	/// <typeparam name="T">The type to be contained.</typeparam>
-	[SuppressMessage("ReSharper", "MemberCanBeProtected.Global")]
 	public class Container<T> : ContainerBase<T>
 	{
 		private Func<T>? _valueFactory;

IsActiveExtension.cs

@@ -14,21 +14,15 @@ public static bool IsActive(this Task target)
 			if (target is null)
 				throw new NullReferenceException();
 
-			switch (target.Status)
+			return target.Status switch
 			{
-				case TaskStatus.Created:
-				case TaskStatus.Running:
-				case TaskStatus.WaitingForActivation:
-				case TaskStatus.WaitingForChildrenToComplete:
-				case TaskStatus.WaitingToRun:
-					return true;
-					//case TaskStatus.Canceled:
-					//case TaskStatus.Faulted:
-					//case TaskStatus.RanToCompletion:
-					//	return false;
-			}
-
-			return false;
+				TaskStatus.Created or
+				TaskStatus.Running or
+				TaskStatus.WaitingForActivation or
+				TaskStatus.WaitingForChildrenToComplete or
+				TaskStatus.WaitingToRun => true,
+				_ => false,
+			};
 		}
 	}
 }

ModificationSynchronizedBase.cs

@@ -1,14 +1,10 @@
 
 using Open.Disposable;
 using System;
-using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 
 namespace Open.Threading
 {
-
-
-	[SuppressMessage("ReSharper", "VirtualMemberCallInConstructor")]
 	public abstract class ModificationSynchronizedBase : DisposableBase
 	{
 

ModificationSynchronizer.cs

@@ -1,6 +1,5 @@
 using Open.Disposable;
 using System;
-using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 
 namespace Open.Threading
@@ -13,7 +12,6 @@ public interface IReadOnlyModificationSynchronizer
 		T Reading<T>(Func<T> action);
 	}
 
-	[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 	public interface IModificationSynchronizer : IReadOnlyModificationSynchronizer
 	{
 

Open.Threading.csproj

@@ -4,6 +4,7 @@
 		<TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
 		<LangVersion>latest</LangVersion>
 		<Nullable>enable</Nullable>
+		<EnableNETAnalyzers>true</EnableNETAnalyzers>
 		<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
 		<Authors>electricessence</Authors>
 		<Description>

Progress.cs

@@ -4,7 +4,6 @@
 
 namespace Open.Threading
 {
-	[SuppressMessage("ReSharper", "UnusedAutoPropertyAccessor.Global")]
 	public class Progress
 	{
 		public Progress()
@@ -78,7 +77,7 @@ public void Run(Action closure, bool propagateException = false)
 		}
 
 #if NETSTANDARD2_1
-		[return:MaybeNull]
+		[return: MaybeNull]
 #endif
 		public T Execute<T>(Func<T> query, bool propagateException = false)
 		{

ThreadSafety.cs

@@ -16,25 +16,20 @@ namespace Open.Threading
 	public static class ThreadSafety
 	{
 		public static bool IsValidSyncObject(object syncObject)
-		{
-			// Avoid the lock object being immutable...
-			switch (syncObject)
+			=> syncObject switch // Avoid the lock object being immutable...
 			{
-				case string _:
-				case ValueType _:
-				case null:
-					return false;
-			}
-
-			return true;
-		}
+				string _ or
+				ValueType _ or
+				null => false,
+				_ => true,
+			};
 
 		internal static void ValidateSyncObject(object syncObject)
 		{
 			if (syncObject is null)
 				throw new ArgumentNullException(nameof(syncObject));
 			if (!IsValidSyncObject(syncObject))
-				throw new ArgumentException(nameof(syncObject));
+				throw new ArgumentException("Is not valid sync object.", nameof(syncObject));
 		}
 
 		internal static void ValidateMillisecondsTimeout(int? millisecondsTimeout)
@@ -364,7 +359,7 @@ public static T InitializeValue<T>(ref Lazy<T> lazy, Func<T> factory)
 		}
 
 		private static readonly ConditionalWeakTable<object, ReadWriteHelper<object>> _sychronizeReadWriteRegistry
-			= new ConditionalWeakTable<object, ReadWriteHelper<object>>();
+			= new();
 
 		private static ReadWriteHelper<object> GetReadWriteHelper(object key)
 		{
@@ -739,7 +734,7 @@ public static bool SynchronizeWrite<TSync>(TSync syncObject, Action closure, int
 		public class Helper<TKey, TSyncObject>
 			where TSyncObject : class, new()
 		{
-			protected readonly ConcurrentDictionary<TKey, TSyncObject> _locks = new ConcurrentDictionary<TKey, TSyncObject>();
+			protected readonly ConcurrentDictionary<TKey, TSyncObject> _locks = new();
 
 			/// <summary>
 			/// Returns a unique object based on the provied cacheKey for use in synchronization.