Skip to content

Commit 9d08d2d

Browse files
authored
Merge pull request #68 from Open-STEM/rangefinder-fix
fix rangefinder returning zeros
2 parents 8f467ca + bc544d6 commit 9d08d2d

File tree

3 files changed

+2
-20
lines changed

3 files changed

+2
-20
lines changed

XRPLib/differential_drive.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ def turn(self, turn_degrees: float, max_effort: float = 0.5, timeout: float = No
278278
turn_error = turn_degrees - ((right_delta-left_delta)/2)*360/(self.track_width*math.pi)
279279

280280
# Pass the turn error to the main controller to get a turn speed
281-
turn_speed = main_controller.update(turn_error, True)
281+
turn_speed = main_controller.update(turn_error)
282282

283283
# exit if timeout or tolerance reached
284284
if main_controller.is_done() or time_out.is_done():

XRPLib/rangefinder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def distance(self) -> float:
6161
"""
6262
Get the distance in centimeters by measuring the echo pulse time
6363
"""
64-
if time.ticks_diff(time.ticks_us(), self.last_echo_time) < self.cache_time_us and not self.cms == 65535:
64+
if time.ticks_diff(time.ticks_us(), self.last_echo_time) < self.cache_time_us and not (self.cms == 65535 or self.cms == 0):
6565
return self.cms
6666

6767
try:

mainprogram.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,3 @@
11

22

33
from XRPLib.encoded_motor import EncodedMotor
4-
import time
5-
from XRPLib.differential_drive import DifferentialDrive
6-
7-
differentialDrive = DifferentialDrive.get_default_differential_drive()
8-
9-
def turn_test(angle, effort):
10-
for i in range(2):
11-
differentialDrive.turn(angle, effort)
12-
differentialDrive.turn(-angle, effort)
13-
differentialDrive.stop()
14-
15-
16-
turn_test(30, 0.5)
17-
turn_test(180, 0.5)
18-
turn_test(30, 0.75)
19-
turn_test(180, 0.75)
20-
turn_test(30, 1)
21-
turn_test(180, 1)

0 commit comments

Comments
 (0)