appease linters

Author: ineskhou

FprimeZephyrReference/Components/Burnwire/Burnwire.cpp

@@ -12,19 +12,31 @@ namespace Components {
 // Component construction and destruction
 // ----------------------------------------------------------------------
 
-Burnwire ::Burnwire(const char* const compName) : BurnwireComponentBase(compName) {}
+Burnwire ::Burnwire(const char* const compName) : BurnwireComponentBase(compName) {
+    this->m_safetyCounter = 0;
+    this->m_state = Fw::On::OFF;
+    Fw::ParamValid valid;
+    this->m_safetyMaxCount = this->paramGet_SAFETY_TIMER(valid);
+    this->log_ACTIVITY_HI_SafetyTimerSet(this->m_safetyMaxCount);
+    this->log_ACTIVITY_HI_SafetyTimerSet(m_safetyMaxCount);
+}
 
 Burnwire ::~Burnwire() {}
 
 // ----------------------------------------------------------------------
 // Handler implementations for typed input ports
 // ----------------------------------------------------------------------
 void Burnwire ::burnStart_handler(FwIndexType portNum) {
-    // TODO
+    this->m_safetyCounter = 0;
+    this->m_state = Fw::On::ON;
+    this->log_ACTIVITY_HI_SetBurnwireState(Fw::On::ON);
 }
 
 void Burnwire ::burnStop_handler(FwIndexType portNum) {
-    // TODO
+    this->m_state = Fw::On::OFF;
+    this->log_ACTIVITY_HI_SetBurnwireState(Fw::On::OFF);
+    this->gpioSet_out(0, Fw::Logic::LOW);
+    this->gpioSet_out(1, Fw::Logic::LOW);
 }
 
 // void Burnwire ::stop_handler(FwIndexType portNum) {
@@ -40,7 +52,7 @@ void Burnwire ::schedIn_handler(FwIndexType portNum, U32 context) {
             this->log_ACTIVITY_HI_SafetyTimerStatus(Fw::On::ON);
         }
 
-        if (this->m_safetyCounter >= m_safetyMaxCount) {
+        if (this->m_safetyCounter >= this->m_safetyMaxCount) {
             // 30 seconds reached → turn OFF
             this->gpioSet_out(0, Fw::Logic::LOW);
             this->gpioSet_out(1, Fw::Logic::LOW);
@@ -56,14 +68,12 @@ void Burnwire ::schedIn_handler(FwIndexType portNum, U32 context) {
 // Handler implementations for commands
 // ----------------------------------------------------------------------
 
-void Burnwire ::START_BURNWIRE_cmdHandler(FwOpcodeType opCode, U32 cmdSeq) {
-    // reset count to 0
+void Burnwire ::START_BURNWIRE_cmdHandler(FwOpcodeType opCode, U32 cmdSeq, U32 max_duration) {
     this->m_safetyCounter = 0;
-    // update private member variable
+    this->m_safetyMaxCount = max_duration;
     this->m_state = Fw::On::ON;
-    // send event
     this->log_ACTIVITY_HI_SetBurnwireState(Fw::On::ON);
-    // confirm response
+    this->log_ACTIVITY_HI_SafetyTimerSet(max_duration);
     this->cmdResponse_out(opCode, cmdSeq, Fw::CmdResponse::OK);
 }
 
@@ -75,4 +85,13 @@ void Burnwire ::STOP_BURNWIRE_cmdHandler(FwOpcodeType opCode, U32 cmdSeq) {
     this->gpioSet_out(1, Fw::Logic::LOW);
 }
 
+void Burnwire ::parameterUpdated(FwPrmIdType id) {
+    if (id == this->PARAMID_SAFETY_TIMER) {
+        Fw::ParamValid valid;
+        this->m_safetyMaxCount = this->paramGet_SAFETY_TIMER(valid);
+        this->log_ACTIVITY_HI_SafetyTimerSet(this->m_safetyMaxCount);
+    }
+    this->log_ACTIVITY_HI_SafetyTimerSet(m_safetyMaxCount);
+}
+
 }  // namespace Components

FprimeZephyrReference/Components/Burnwire/Burnwire.fpp

@@ -8,8 +8,11 @@ module Components {
 
         # @ Examplesync command
         sync command START_BURNWIRE(
+            max_duration: U32
         )
 
+
+
         sync command STOP_BURNWIRE(
         )
 
@@ -26,6 +29,10 @@ module Components {
             severity activity high\
             format "Safety Timer State: {} "
 
+        event SafetyTimerSet(max_duration: U32) \
+            severity activity high\
+            format "Safety Timer Set to: {} seconds"
+
         # @ Example port: receiving calls from the rate group
         # sync input port run: Svc.Sched
 
@@ -43,6 +50,7 @@ module Components {
 
         # @ Example parameter
         # param PARAMETER_NAME: U32
+        param SAFETY_TIMER: U32 default 5
 
         ###############################################################################
         # Standard AC Ports: Required for Channels, Events, Commands, and Parameters  #

FprimeZephyrReference/Components/Burnwire/Burnwire.hpp

@@ -50,21 +50,23 @@ class Burnwire final : public BurnwireComponentBase {
                          U32 context           //!< The call order
                          ) override;
 
+    void parameterUpdated(FwPrmIdType id) override;
+
   private:
     // ----------------------------------------------------------------------
     // Handler implementations for commands
     // ----------------------------------------------------------------------
 
     //! Handler implementation for command START_BURNWIRE
-    void START_BURNWIRE_cmdHandler(FwOpcodeType opCode, U32 cmdSeq) override;
+    void START_BURNWIRE_cmdHandler(FwOpcodeType opCode, U32 cmdSeq, U32 max_duration) override;
 
     //! Handler implementation for command STOP_BURNWIRE
     void STOP_BURNWIRE_cmdHandler(FwOpcodeType opCode, U32 cmdSeq) override;
 
     Fw::On m_state = Fw::On::OFF;      // keeps track if burnwire is on or off
     std::atomic<U32> m_safetyCounter;  // makes this an atomic variable (so its set only in one command),
                                        // you read and write half the value bc a corrupted read could be dangerouts
-    U32 m_safetyMaxCount = 5;          // make this a aparamater
+    U32 m_safetyMaxCount = 5;          // max count for safety timer (default 10 seconds)
 };
 
 }  // namespace Components