feedback from deign review

Author: ineskhou

FprimeZephyrReference/Components/Burnwire/Burnwire.cpp

@@ -28,6 +28,8 @@ void Burnwire ::schedIn_handler(FwIndexType portNum, U32 context) {
     if (this->m_state == Fw::On::ON) {
         this->m_safetyCounter++;
         if (this->m_safetyCounter == 1) {
+            this->gpioSet_out(0, Fw::Logic::HIGH);
+            this->gpioSet_out(1, Fw::Logic::HIGH);
             this->log_ACTIVITY_HI_SafetyTimerStatus(Fw::On::ON);
         }
 
@@ -48,18 +50,14 @@ void Burnwire ::schedIn_handler(FwIndexType portNum, U32 context) {
 // ----------------------------------------------------------------------
 
 void Burnwire ::START_BURNWIRE_cmdHandler(FwOpcodeType opCode, U32 cmdSeq) {
+    // reset count to 0
+    this->m_safetyCounter = 0;
     // update private member variable
     this->m_state = Fw::On::ON;
     // send event
     this->log_ACTIVITY_HI_SetBurnwireState(Fw::On::ON);
     // confirm response
     this->cmdResponse_out(opCode, cmdSeq, Fw::CmdResponse::OK);
-
-    // reset count to 0
-    this->m_safetyCounter = 0;
-
-    this->gpioSet_out(0, Fw::Logic::HIGH);
-    this->gpioSet_out(1, Fw::Logic::HIGH);
 }
 
 void Burnwire ::STOP_BURNWIRE_cmdHandler(FwOpcodeType opCode, U32 cmdSeq) {

FprimeZephyrReference/Components/Burnwire/Burnwire.hpp

@@ -49,8 +49,10 @@ class Burnwire final : public BurnwireComponentBase {
     void STOP_BURNWIRE_cmdHandler(FwOpcodeType opCode, U32 cmdSeq) override;
 
     Fw::On m_state = Fw::On::OFF;  // keeps track if burnwire is on or off
-    U32 m_safetyCounter = 0;       // keeps track of the safety number of seconds
-    U32 m_safetyMaxCount = 5;
+    std::atomic<U32>
+        m_safetyCounter;  // makes this an atomic variable (so its set only in one comnmdn), so you won't have smth so
+                          // you read and write half the value bc a corrupted read could be dangerouts
+    U32 m_safetyMaxCount = 5;  // make this a aparamater
 };
 
 }  // namespace Components

FprimeZephyrReference/Components/Burnwire/docs/sdd.md

@@ -1,22 +1,36 @@
 # Components::Burnwire
 
-Turns Burnwire on and off
+Driving the Burnwire on and off. The deployment will be handled by the Antenna Deployment component TODO ADD details
+
+## Sequence Diagrams
+Add sequence diagrams here
 
 ## Requirements
 Add requirements in the chart below
 | Name | Description | Validation |
-|BW-001|The burnwire component shall turn on when commanded to |Hardware Test|
-|BW-002|The burnwire component shall turn off when commanded to |Hardware Test|
+| ---- | -----------  | ------ |
+|BW-001|The burnwire shall turn on in response to a port call |Hardware Test|
+|BW-002|The burnwire shall turn off in response to a port call |Hardware Test|
 |BW-003|The burnwire component shall provide an Event when it is turned on and off |Integration Test|
 |BW-004|The burnwire component shall activate by turning the GPIO pins on one at a time |Integration Test|
-|BW-005|The burnwire component shall be controlled by a safety timeout that can be changed within the code |Integration Test|
+|BW-005|The burnwire component shall be controlled by a safety timeout attached to a 1Hz rate group that can be changed within the code |Integration Test|
+|BW-006|The burnwire safety time shall emit an event when it starts and stops |Integration Test|
+
+
+Use the Zephyr GPIO driver --> so that the GPIO driver can be changed instead of being hardcoded
+checking is it calling that set port, break the two layers out
+Write, read get interrupt from GPIO
+single port of type driver.gPIO write that is a port on your FPP
 
 
 ## Port Descriptions
-| Name | Description |
-|---|---|
-|Fw::Signal|Receive stop signal to stop and start burnwire|
-|Drv::GpioWrite|Control GPIO state to driver|
+Name | Type | Description |
+|----|---|---|
+|----|`Fw::Signal`|Receive stop signal to stop the burnwire|
+|----|`Fw::Signal`|Receive start signal to start burnwire|
+|----|`Drv::GpioWrite`|Control GPIO state to driver|
+|schedIn|[`Svc::Sched`]| run | Input | Synchronous | Receive periodic calls from rate group
+
 
 ## Commands
 | Name | Description |
@@ -37,31 +51,15 @@ Add component states in the chart below
 |----|---|
 |m_state|Keeps track if the burnwire is on or off|
 
-## Sequence Diagrams
-Add sequence diagrams here
-
-## Parameters
-| Name | Description |
-|---|---|
-|---|---|
-
-
-
-
-
-## Telemetry
-| Name | Description |
-|---|---|
-|---|---|
 
 ## Unit Tests
 Add unit test descriptions in the chart below
 | Name | Description | Output | Coverage |
 |TestSafety|Tests Burnwire turns off after X seconds|---|---|
 |TestOn|Tests right GPIO pins turn on |---|---|
-|TestOn|Tests right GPIO pins turn off, same as on |---|---|
+|TestOn|Tests right GPIO pins turn off, same as |---|---|
 
-## Change Log
-| Date | Description |
-|---|---|
-|---| Initial Draft |
+
+## Parameter
+| Name | Description |
+| ---- | ----------- |

FprimeZephyrReference/ReferenceDeployment/Top/ReferenceDeploymentTopology.cpp

@@ -14,6 +14,8 @@
 #include <zephyr/drivers/gpio.h>
 
 static const struct gpio_dt_spec ledGpio = GPIO_DT_SPEC_GET(DT_ALIAS(led0), gpios);
+// static const struct gpio_dt_spec ledGpio = GPIO_DT_SPEC_GET(DT_ALIAS(burnwire0), gpios);
+
 static const struct gpio_dt_spec burnwire0Gpio = {
     .port = DEVICE_DT_GET(DT_NODELABEL(gpio0)),
     .pin = 28,  // 28

boards/rpi_pico2_rp2350a_m33.overlay

@@ -9,6 +9,11 @@
         zephyr,console = &cdc_acm_uart0;
     };
 
+    aliases {
+        burnwire0 = &burnwire0;
+        burnwire1 = &burnwire1;
+    };
+
     burnwire0: burnwire0 {
         gpios = <&gpio0 28 GPIO_ACTIVE_HIGH>;
         label = "Burnwire 0, 28";
@@ -19,10 +24,6 @@
         label = "Burnwire 1, 29";
     };
 
-    aliases {
-        burnwire0 = &burnwire0;
-        burnwire1 = &burnwire1;
-    };
 };
 
 /* Override the default LED definition to use GPIO 24 instead of GPIO 25 for PROVES FC board*/