Fix gpio inputs #100
Merged
Fix gpio inputs #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect GPIO expander pin assignments for the charge and readonly input pins on the MCP23017 GPIO expander.
Key Changes:
- Corrected charge pin from 16 to 15 (GPB7)
- Corrected readonly pin from 15 to 14 (GPB6)
- Aligns pin numbers with the documented mapping in gpio-line-names comment
Mikefly123
approved these changes
Nov 13, 2025
Contributor
Mikefly123
left a comment
Mikefly123
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the quick patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gpio expander pins
Related Issues/Tickets
#86 (comment)
How Has This Been Tested?
Further Notes / Considerations
I don't have the means to do any testing right now, but this information can be confirmed by other parts of the code.