Skip to content

Conversation

@ineskhou
Copy link
Contributor

@ineskhou ineskhou commented Sep 10, 2025

Description

This adds Burnwire component into the topology

How has this been tested?

  • Unit tests
  • Integration tests
  • Z Tests
  • Manual testing: Ran the burnwire, felt it get hot and tested different safety timers

Checklist

  • Written detailed sdd with requirements, channels, ports, commands, telemetry defined and correctly formatted and spelled
  • Have written relevant integration tests and have documented them in the sdd
  • Have done a code review with
  • Have tested this PR on every supported board with correct board definitions

@ineskhou ineskhou moved this to In progress in v0.1-v0.3 Sep 10, 2025
@ineskhou ineskhou moved this from In progress to In review in v0.1-v0.3 Sep 10, 2025
@ineskhou ineskhou moved this from In review to In progress in v0.1-v0.3 Sep 10, 2025
@Mikefly123 Mikefly123 requested a review from Copilot October 4, 2025 16:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new burnwire component to the F´ reference deployment for controlling burn wire hardware, along with associated GPIO pins and safety features.

  • Adds burnwire component with GPIO control, safety timer, and command/port interfaces
  • Updates hardware configuration to support two new GPIO pins for burnwire control
  • Includes documentation, integration tests, and topology integration

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
settings.ini Updates board configuration to v5d
boards/bronco_space/proves_flight_control_board_v5/proves_flight_control_board_v5.dtsi Adds GPIO pin definitions for two burnwire pins
README.md Adds comprehensive documentation for adding components (with merge conflict)
Makefile Adds blank lines
FprimeZephyrReference/test/int/burnwire_test.py Adds integration tests for burnwire functionality
FprimeZephyrReference/ReferenceDeployment/Top/topology.fpp Adds burnwire instances and connections to topology
FprimeZephyrReference/ReferenceDeployment/Top/instances.fpp Adds burnwire component instances with base IDs
FprimeZephyrReference/ReferenceDeployment/Top/ReferenceDeploymentTopology.cpp Adds GPIO device tree configuration for burnwire pins
FprimeZephyrReference/ReferenceDeployment/Main.cpp Adds debug print statements
FprimeZephyrReference/Components/ImuManager/ImuManager.cpp Adds debug print statement
FprimeZephyrReference/Components/Drv/RtcManager/RtcManager.cpp Adds debug print statement
FprimeZephyrReference/Components/CMakeLists.txt Adds burnwire component to build
FprimeZephyrReference/Components/Burnwire/docs/sdd.md Adds component documentation
FprimeZephyrReference/Components/Burnwire/CMakeLists.txt Adds burnwire component build configuration
FprimeZephyrReference/Components/Burnwire/Burnwire.hpp Adds burnwire component header file
FprimeZephyrReference/Components/Burnwire/Burnwire.fpp Adds burnwire component F´ definition
FprimeZephyrReference/Components/Burnwire/Burnwire.cpp Adds burnwire component implementation
FprimeZephyrReference/Components/BootloaderTrigger/BootloaderTrigger.cpp Adds debug print statement
Comments suppressed due to low confidence (1)

FprimeZephyrReference/Components/Burnwire/Burnwire.hpp:1

  • Corrected spelling of 'mabger' to 'manager'.
// ======================================================================

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ineskhou ineskhou self-assigned this Oct 5, 2025
@ineskhou
Copy link
Contributor Author

ineskhou commented Oct 8, 2025

Turns out that the burnwire test sends its first command before the gds actually starts. While sleeping and other asserts doesn't seem to help much, moving it to be after a test that doesnt send commands (ie imu_manager tests) allows to it succead properlly on the runner. More experimentation should be done to properly understand this issue

@ineskhou ineskhou requested a review from nateinaction October 8, 2025 19:15
@ineskhou ineskhou moved this from In progress to In review in v0.1-v0.3 Oct 8, 2025
@ineskhou ineskhou merged commit 3f8c021 into main Oct 9, 2025
3 checks passed
@ineskhou ineskhou deleted the burnwire branch October 9, 2025 00:55
@github-project-automation github-project-automation bot moved this from In review to Done in v0.1-v0.3 Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants