Ensure watchdog integration test cleans up after itself #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateinaction
commented
Sep 27, 2025
| // Only perform actions when stop not requested | ||
| if (!this->m_stopRequested) { | ||
| // Only perform actions when run is enabled | ||
| if (this->m_run) { |
Collaborator
Author
There was a problem hiding this comment.
Swapped logic from running when false to running when true. Helps me understand the state of the watchdog.
nateinaction
commented
Sep 27, 2025
| @ Command to stop the watchdog petter | ||
| sync command TEST_STOP_WATCHDOG( | ||
| @ Command to stop the watchdog | ||
| sync command STOP_WATCHDOG( |
Collaborator
Author
There was a problem hiding this comment.
Changed command name to no longer be prefixed by TEST_. I believe disabling the watchdog via command (causing a hard reboot) is one of the original requirements so it feels like it's no longer a "test command"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure watchdog integration test cleans up after itself
Description
Currently the watchdog tests permanently stop the watchdog, this PR ensures the watchdog is restarted after the tests complete.
How Has This Been Tested?
Screenshots / Recordings (if applicable)
Checklist
Further Notes / Considerations