Add Watchdog Petter Component #3
Conversation
moisesmata
changed the title
moisesmata
changed the title
…-core-reference into more-led-blinker
|
I think this is looking great @moisesmata! Let's take the time to do a review when you're in the lab on Wednesday and if all looks good then I think we can go ahead and get this merged in |
|
Thanks, sounds good! |
There was a problem hiding this comment.
@Mikefly123 @moisesmata We mentioned in the meeting with @LeStarch that we want to require unit tests. Is that something we can set up with this PR?
| namespace ReferenceDeployment_rateGroup1Hz { | ||
| enum { WARN = 3, FATAL = 5 }; | ||
| } | ||
| namespace ReferenceDeployment_prmDb { |
There was a problem hiding this comment.
What does prmDb stand for?
There was a problem hiding this comment.
prmDb is the parameter database component needed by default to use parameters in F'. When this was strictly an LED component, it used a parameter to vary the interval (like the tutorial). Now we just tick every rategroup and use no parameter, but will probably use parameters later on in the project, so I'd just keep this component in.
There was a problem hiding this comment.
How did you generate this svg?
There was a problem hiding this comment.
I think this is now natively a part of the fprime-fpp extension on vscode!
There was a problem hiding this comment.
Yeah! The vscode extension can now visualize topologies and components on the fly with real time updates! I can do a demo on Wednesday if we want! @nateinaction @Mikefly123
Oh yeah, I hadn't thought about that since this is such a simple component, but it would be nice to get that going as soon as we can! |
|
Any thoughts on keeping the LED component? I've been showing it to my team as we go through the fprime docs and playing in the GDS. Totally fine if we want to keep it on a branch. Just wanted to ask for thoughts. Thoughts? |
Down to make a unit test for this, discuss more on Wednesday? |
I'm open to this! We can just assign it to a different led and keep it as a good way to test commands and get instant feedback. |
At the moment there actually aren't any additional LEDs that won't have another purpose in flight (the UART line has status LEDs, the white ones on the back of the board!). Maybe a good way to do this is to split the LED blinker component into its own LED tutorial deployment and abstract it into a GPIO manipulator component? Not sure how possible this is with the current Zephyr setup (since I think I remember you saying you were using the Zephyr LED type as a basis for this component) but the idea is you can add to the component a parameter that lets you select from a list of options all of the GPIO on the RP2350 then set any of them to be on/off/blinking. That way it can also be used as a more general hardware tutorial as well or a middleware for controlling GPIO if we want to overcomplicate the downstream code lol |
Mikefly123
left a comment
Mikefly123
left a comment
There was a problem hiding this comment.
LGTM!
Great work on this, an awesome template to jump off into the rest of the development! 🚀
Known Issues: