Update Lis2mdlManager and Lsm6dsoManager with best practices
#78
+76
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikefly123
approved these changes
Nov 5, 2025
Comment on lines
+22
to
+23
| # DEPENDS | ||
| # FprimeZephyrReference_Components_Drv_Helpers |
There was a problem hiding this comment.
Suggested change
| # DEPENDS | |
| # FprimeZephyrReference_Components_Drv_Helpers |
Should we just remove this if the Helpers are gone?
There was a problem hiding this comment.
You've got a point. I guess I left this line because for every generated component it is commented out. It doesn't say FprimeZephyrReference_Components_Drv_Helpers but instead MyPackage_MyOtherModule: https://github.com/Open-Source-Space-Foundation/proves-core-reference/blob/main/FprimeZephyrReference/Components/Burnwire/CMakeLists.txt#L22-L23
I think it's OK to leave this for now but maybe we should go remove them from all packages if we end up doing a cleanup some day...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
Lis2mdlManagerandLsm6dsoManagerwith learnings from #76.HelpersclassMain.cppto allow multiple instances of the component to be created.m_prefix to signify member variables and usethis->notation whenever referencing themRelated Issues/Tickets
How Has This Been Tested?
Verified component still works:
Screenshots / Recordings (if applicable)
Checklist
Further Notes / Considerations