-
Notifications
You must be signed in to change notification settings - Fork 4
updated instrucitons in case people get confsued like i did #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ineskhou and @hrfarmer. I realize this has already been merged in, but I am a little unclear on what issue is being solved here. You shouldn't have to clone the repo in order to setup an integration test runner, the CI system should be doing that for you when it runs
ci.yaml.Are you guys running into the shadow
.westin the parent directory problem? If so I think the fix would actually be to make sure wherever you setup the actions runner is encapsulated in at least one layer of folder structure away from any other Zephyr environments so there aren't conflicts.For example on the
deathstarfromhomeI created aproves-ci/runnerfolder and then put the runner in there. So if and when the repo creates the.westin the parent directory there is little chance it propagates issues to other repos.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was no west directory created automatically, which causes a “no west” error when running integration tests for the first time. It seems that when we moved the Zephyr-related steps into the Make process, the runner setup started missing a few initialization steps.
When I last set up a runner on this same computer, it worked without needing any extra steps, but yesterday it didn’t work out of the box. The runner is typically located two folders above any West repository, plus the two directories created during setup. However, running make in the folder where everything is automatically cloned resolves the issue.
We decided to update the instructions to have users run make right after encountering the integration test failure, since that made the process clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ref without running make
