#2650 reload with same settings fails (#2774)

Author: benjaperez1983

src/OSPSuite.Presentation/Services/DataImporter.cs

@@ -88,6 +88,11 @@ string dataFileName
       public override ReloadDataSets CalculateReloadDataSetsFromConfiguration(IReadOnlyList<DataRepository> dataSetsToImport,
          IReadOnlyList<DataRepository> existingDataSets)
       {
+         // If the import returned nothing (e.g. all sheets missing or a parsing exception), do not
+         // proceed with the reload dialog. The error was already shown and there is nothing to reload.
+         if (!dataSetsToImport.Any())
+            return new ReloadDataSets();
+
          var newDataSets = dataSetsToImport.Where(dataSet => !repositoryExistsInList(existingDataSets, dataSet)).ToList();
          var dataSetsToBeDeleted = existingDataSets.Where(dataSet => !repositoryExistsInList(dataSetsToImport, dataSet));
          var overwrittenDataSets = dataSetsToImport.Except(newDataSets);

tests/OSPSuite.UI.Tests/Services/DataImporterSpecs.cs

@@ -229,4 +229,34 @@ public void should_return_one_deleted_data_sets()
          _result.DataSetsToBeDeleted.Any(x => x.Name == "repo2").ShouldBeTrue();
       }
    }
+
+   public class When_reloading_configuration_but_no_data_sets_were_imported : concern_for_DataImporter
+   {
+      private ReloadDataSets _result;
+
+      protected override void Context()
+      {
+         base.Context();
+         _dataSetsToImport = new List<DataRepository>();
+      }
+
+      protected override void Because()
+      {
+         _result = sut.CalculateReloadDataSetsFromConfiguration(_dataSetsToImport, _existingDataSets);
+      }
+
+      [Test]
+      public void should_return_empty_reload_result()
+      {
+         _result.DataSetsToBeDeleted.Count().ShouldBeEqualTo(0);
+         _result.NewDataSets.Count().ShouldBeEqualTo(0);
+         _result.OverwrittenDataSets.Count().ShouldBeEqualTo(0);
+      }
+
+      [Test]
+      public void should_not_show_the_reload_dialog()
+      {
+         A.CallTo(() => _applicationController.Start<IImporterReloadPresenter>()).MustNotHaveHappened();
+      }
+   }
 }