#2693 code changs

benjaperez1983 · benjaperez1983 · commit 53dcd6e9c7ff · 2025-10-29T16:14:40.000+01:00
diff --git a/src/OSPSuite.Core/Converters/v13/Converter121To130.cs b/src/OSPSuite.Core/Converters/v13/Converter121To130.cs
@@ -30,7 +30,7 @@ public Converter121To130(ISolverSettingsFactory solverSettingsFactory)
       public (int convertedToVersion, bool conversionHappened) Convert(object objectToUpdate)
       {
          _converted = false;
-         performConversion(objectToUpdate);
+         this.Visit(objectToUpdate);
          return (PKMLVersion.V13_0, _converted);
       }
 
@@ -39,8 +39,6 @@ public Converter121To130(ISolverSettingsFactory solverSettingsFactory)
          return (PKMLVersion.V13_0, false);
       }
 
-      private void performConversion(object objectToUpdate) => this.Visit(objectToUpdate);
-
       public void Visit(SimulationTransfer simulationTransfer)
       {
          Visit(simulationTransfer.Simulation);
diff --git a/src/OSPSuite.R/Services/SimulationRunner.cs b/src/OSPSuite.R/Services/SimulationRunner.cs
@@ -124,7 +124,7 @@ private async Task<SimulationResults> runAsync(IModelCoreSimulation simulation,
       private Core.Domain.SimulationRunOptions coreSimulationRunOptionsFrom(SimulationRunOptions simulationRunOptions, IModelCoreSimulation simulation)
       {
          var options = simulationRunOptions ?? new SimulationRunOptions();
-         options.CheckForNegativeValues = simulation.Settings?.Solver?.CheckForNegativeValues ?? false;
+         options.CheckForNegativeValues = simulation.Settings.Solver.CheckForNegativeValues;
          return new Core.Domain.SimulationRunOptions
          {
             CheckForNegativeValues = options.CheckForNegativeValues,

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public Converter121To130(ISolverSettingsFactory solverSettingsFactory)`
`30`	`30`	`public (int convertedToVersion, bool conversionHappened) Convert(object objectToUpdate)`
`31`	`31`	`{`
`32`	`32`	`_converted = false;`
`33`		`- performConversion(objectToUpdate);`
	`33`	`+ this.Visit(objectToUpdate);`
`34`	`34`	`return (PKMLVersion.V13_0, _converted);`
`35`	`35`	`}`
`36`	`36`
`@@ -39,8 +39,6 @@ public Converter121To130(ISolverSettingsFactory solverSettingsFactory)`
`39`	`39`	`return (PKMLVersion.V13_0, false);`
`40`	`40`	`}`
`41`	`41`
`42`		`- private void performConversion(object objectToUpdate) => this.Visit(objectToUpdate);`
`43`		`-`
`44`	`42`	`public void Visit(SimulationTransfer simulationTransfer)`
`45`	`43`	`{`
`46`	`44`	`Visit(simulationTransfer.Simulation);`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ private async Task<SimulationResults> runAsync(IModelCoreSimulation simulation,`
`124`	`124`	`private Core.Domain.SimulationRunOptions coreSimulationRunOptionsFrom(SimulationRunOptions simulationRunOptions, IModelCoreSimulation simulation)`
`125`	`125`	`{`
`126`	`126`	`var options = simulationRunOptions ?? new SimulationRunOptions();`
`127`		`- options.CheckForNegativeValues = simulation.Settings?.Solver?.CheckForNegativeValues ?? false;`
	`127`	`+ options.CheckForNegativeValues = simulation.Settings.Solver.CheckForNegativeValues;`
`128`	`128`	`return new Core.Domain.SimulationRunOptions`
`129`	`129`	`{`
`130`	`130`	`CheckForNegativeValues = options.CheckForNegativeValues,`