Fixes #2767 Make preview option sticky in projects (#2768)

* Fixes #2767 Make preview option sticky in projects

* pr feedback

Author: rwmcintosh

src/OSPSuite.Core/Chart/Mappers/CurveChartToCurveChartTemplateMapper.cs

@@ -25,6 +25,7 @@ public CurveChartTemplate MapFrom(CurveChart curveChart)
             return template;
 
          template.IncludeOriginData = curveChart.IncludeOriginData;
+         template.PreviewSettings = curveChart.PreviewSettings;
          template.ChartSettings.UpdatePropertiesFrom(curveChart.ChartSettings, _cloneManager);
          template.FontAndSize.UpdatePropertiesFrom(curveChart.FontAndSize, _cloneManager);
          curveChart.Curves.Each(curve => template.Curves.Add(curveFrom(curve)));

src/OSPSuite.Core/Serialization/Chart/CurveChartTemplateXmlSerializer.cs

@@ -11,6 +11,7 @@ public override void PerformMapping()
          Map(x => x.IncludeOriginData);
          Map(x => x.FontAndSize);
          Map(x => x.Name);
+         Map(x => x.PreviewSettings);
          MapEnumerable(x => x.Axes, x => x.AddAxis);
          MapEnumerable(x => x.Curves, x => x.Curves.Add);
          Map(x => x.IsDefault);

src/OSPSuite.Core/Serialization/Chart/CurveChartXmlSerializer.cs

@@ -17,6 +17,7 @@ public override void PerformMapping()
          Map(x => x.Name);
          Map(x => x.Title);
          Map(x => x.Description);
+         Map(x => x.PreviewSettings);
          MapEnumerable(x => x.Axes, x => x.AddAxis);
          MapEnumerable(x => x.Curves, x => x.AddCurveIfConsistent);
       }

src/OSPSuite.Presentation/Presenters/Charts/ChartDisplayPresenter.cs

@@ -191,6 +191,11 @@ public interface IChartDisplayPresenter :
       void AddDeviationLines();
 
       Func<IEnumerable<DataColumn>, IEnumerable<DataColumn>> PreExportHook { get; set; }
+
+      /// <summary>
+      /// Applies the watermark to the chart if the chart is in preview mode and auto update is enabled, otherwise does nothing
+      /// </summary>
+      void UpdateWatermark();
    }
 
    public class ChartDisplayPresenter : AbstractPresenter<IChartDisplayView, IChartDisplayPresenter>, IChartDisplayPresenter
@@ -222,6 +227,12 @@ public Action<int> HotTracked
       //by default, don't modify anything
       public Func<IEnumerable<DataColumn>, IEnumerable<DataColumn>> PreExportHook { get; set; } = x => x;
 
+      public void UpdateWatermark()
+      {
+         if (Chart.AutoUpdateEnabled)
+            _view.ShowWatermark(normalWatermark);
+      }
+
       public ChartDisplayPresenter(IChartDisplayView chartDisplayView,
          ICurveBinderFactory curveBinderFactory,
          IViewItemContextMenuFactory contextMenuFactory,
@@ -394,7 +405,7 @@ private void updateChart(IReadOnlyCollection<Curve> curvesToUpdate, bool refresh
       {
          // Make sure binders for curves that were removed are pruned so that their axes are not considered when calculating diagram size
          pruneCurves();
-         
+
          var diagramSize = View.GetDiagramSize();
          using (new BatchUpdate(View))
          {

src/OSPSuite.Presentation/Services/ChartFromTemplateService.cs

@@ -77,6 +77,7 @@ private void updateChartFromTemplateWithMatchingCurves(CurveChart chart, CurveCh
             chart.FontAndSize.UpdatePropertiesFrom(template.FontAndSize, _cloneManager);
             template.Axes.Each(axis => chart.AddAxis(axis.Clone()));
             bestTemplateForCurves.KeyValues.Each(kv => addCurvesToChart(kv.Key, kv.Value, chart));
+            chart.PreviewSettings = template.PreviewSettings;
          }
       }
 

src/OSPSuite.UI/Views/Charts/ChartDisplayView.cs

@@ -191,6 +191,8 @@ private Point chartControlPointFromDragDropEventArgs(DragEventArgs dragOverEvent
       private void onSizeChanged()
       {
          _presenter?.RefreshAxisBinders();
+         if (_presenter?.Chart != null)
+            _presenter?.UpdateWatermark();
       }
 
       private void chartDoubleClick(MouseEventArgs mouseEventArgs)
@@ -568,7 +570,7 @@ private string generateToolTipForSeriesDataPoint(Series series, ChartHitInfo hit
                : null, editable: _curveEditEnabled, description: curveDescription);
       }
 
-      private SeriesPoint findPointInSeries(ChartHitInfo hitInfo, Series series) => 
+      private SeriesPoint findPointInSeries(ChartHitInfo hitInfo, Series series) =>
          hitInfo.SeriesPoint ?? findNextClosestSeriesPoint(hitInfo, series);
 
       private SeriesPoint findNextClosestSeriesPoint(ChartHitInfo hitInfo, Series series)
@@ -586,10 +588,10 @@ private SeriesPoint findNextClosestSeriesPoint(ChartHitInfo hitInfo, Series seri
          return nextPoint;
       }
 
-      private void onObjectSelected(HotTrackEventArgs e) => 
+      private void onObjectSelected(HotTrackEventArgs e) =>
          e.Cancel = true;
 
-      public void SetFontAndSizeSettings(ChartFontAndSizeSettings fontAndSizeSettings) => 
+      public void SetFontAndSizeSettings(ChartFontAndSizeSettings fontAndSizeSettings) =>
          _chartControl.SetFontAndSizeSettings(fontAndSizeSettings, _chartControl.Size);
 
       public void CopyToClipboard(string watermark) => _chartControl.CopyToClipboard(_presenter.Chart, watermark);

tests/OSPSuite.Core.Tests/Mappers/CurveChartToCurveChartTemplateMapperSpecs.cs

@@ -45,6 +45,7 @@ protected override void Context()
          _curveChart.AddAxis(new Axis(AxisTypes.X));
          _curveChart.AddAxis(new Axis(AxisTypes.Y));
          _curveChart.AddAxis(new Axis(AxisTypes.Y2));
+         _curveChart.PreviewSettings = true;
          var curve = new Curve();
          curve.SetxData(_xData, _dimensionFactory);
          curve.SetyData(_yData, _dimensionFactory);
@@ -83,6 +84,12 @@ public void should_have_updated_the_font_and_size()
       {
          _curveChartTemplate.FontAndSize.ChartHeight.ShouldBeEqualTo(500);
       }
+
+      [Observation]
+      public void should_have_the_preview_settings_set()
+      {
+         _curveChart.PreviewSettings.ShouldBeEqualTo(_curveChartTemplate.PreviewSettings);
+      }
    }
 
    public class When_mapping_an_undefined_chart : concern_for_CurveChartToCurveChartTemplateMapper

tests/OSPSuite.Presentation.Tests/Presentation/ChartFromTemplateServiceSpecs.cs

@@ -103,6 +103,9 @@ protected override void Context()
             xData = {QuantityType = QuantityType.BaseGrid},
             yData = {QuantityType = _drugColumn.QuantityInfo.Type, Path = _drugTemplatePathArray.ToPathString()}
          });
+
+         _template.PreviewSettings = true;
+
          _propagateChartChangedEvent = false;
       }
 
@@ -111,6 +114,11 @@ protected override void Because()
          sut.InitializeChartFromTemplate(_chart, _dataColumns, _template, propogateChartChangeEvent:_propagateChartChangedEvent);
       }
 
+      [Observation]
+      public void should_update_the_export_preview_settings_from_the_template()
+      {
+         _chart.PreviewSettings.ShouldBeEqualTo(_template.PreviewSettings);
+      }
 
       [Observation]
       public void should_return_a_chart_with_the_curves_for_the_exact_data()