[client] Add default period when missing a specific config (#75)

Signed-off-by: Antoine MAZEAS <[email protected]>

Author: antoinemzs

pyobas/daemons/collector_daemon.py

@@ -4,6 +4,8 @@
 from pyobas.daemons import BaseDaemon
 from pyobas.utils import PingAlive
 
+DEFAULT_PERIOD_SECONDS = 60
+
 
 class CollectorDaemon(BaseDaemon):
     """Implementation of a daemon of Collector type. Note that it requires
@@ -16,6 +18,8 @@ class CollectorDaemon(BaseDaemon):
     """
 
     def _setup(self):
+        if self._configuration.get("collector_period") is None:
+            self._configuration.set("collector_period", DEFAULT_PERIOD_SECONDS)
         icon_path = self._configuration.get("collector_icon_filepath")
         icon_name = self._configuration.get("collector_id") + ".png"
         with open(icon_path, "rb") as icon_file_handle:

test/daemons/test_collector_daemon.py

@@ -0,0 +1,39 @@
+import unittest
+from unittest.mock import mock_open, patch
+
+from pyobas.configuration import Configuration
+from pyobas.daemons import CollectorDaemon
+from pyobas.daemons.collector_daemon import DEFAULT_PERIOD_SECONDS
+
+
+class TestCollectorDaemon(unittest.TestCase):
+    @patch("pyobas.apis.DocumentManager.upsert")
+    @patch("pyobas.apis.CollectorManager.create")
+    @patch("builtins.open", new_callable=mock_open, read_data="data")
+    @patch("pyobas.utils.PingAlive.start")
+    def test_when_no_period_config_provided_set_default_period(
+        self,
+        mock_ping_alive,
+        mock_open_local,
+        mock_collector_create,
+        mock_document_upsert,
+    ):
+        mock_ping_alive.return_value = None
+        mock_collector_create.return_value = {}
+        mock_document_upsert.return_value = {}
+        config = Configuration(
+            config_hints={
+                "openbas_url": {"data": "fake"},
+                "openbas_token": {"data": "fake"},
+                "collector_id": {"data": "fake id"},
+            }
+        )
+        collector = CollectorDaemon(config)
+
+        collector._setup()
+
+        self.assertEqual(config.get("collector_period"), DEFAULT_PERIOD_SECONDS)
+
+
+if __name__ == "__main__":
+    unittest.main()