-
Notifications
You must be signed in to change notification settings - Fork 173
[backend/frontend] feat: add terminal view on inject result (#3525) #4447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/current
Are you sure you want to change the base?
Conversation
07078c7 to
7bbd3f5
Compare
|
@gabriel-peze I made a rebase and MAYBE I break what you did here: 5cf27f1 |
7bbd3f5 to
193aedc
Compare
|
|
||
| private final InjectExecutionResultService injectExecutionService; | ||
|
|
||
| @GetMapping(INJECT_EXECUTION_URI + "/payload_result") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: We prefer this format (guidelines): /payload-result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well seen, I forget this one.
|
Hey @RomuDeuxfois Apparently everything is ok on your branch.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/current #4447 +/- ##
=====================================================
- Coverage 50.11% 50.08% -0.04%
- Complexity 3636 3639 +3
=====================================================
Files 896 898 +2
Lines 26560 26576 +16
Branches 1989 1989
=====================================================
Hits 13311 13311
- Misses 12450 12466 +16
Partials 799 799 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|

Proposed changes
** back-end: Add a new DTO and a dedicated service and API to fit with the UI screen
** front-end: Add a new hook to handle call and state at the same place
** Refactor TargetResultsDetail component to use TabbedView common component
** Refactor a property on Theme file
** Upgrade react-syntax-highlighter library
Testing Instructions
Related issues