Skip to content

Conversation

@RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Nov 27, 2025

Proposed changes

  • Feature: Add a Terminal View on Inject Result UI
  • Implementation:
    ** back-end: Add a new DTO and a dedicated service and API to fit with the UI screen
    ** front-end: Add a new hook to handle call and state at the same place
  • Improvment:
    ** Refactor TargetResultsDetail component to use TabbedView common component
    ** Refactor a property on Theme file
    ** Upgrade react-syntax-highlighter library
image

Testing Instructions

  1. Run a technical inject
  2. Go to the result component
  3. Click on the new Terminal View tab

Related issues

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • Where necessary I refactored code to improve the overall quality

@RomuDeuxfois RomuDeuxfois force-pushed the issue/3525 branch 3 times, most recently from 07078c7 to 7bbd3f5 Compare November 27, 2025 10:30
@RomuDeuxfois
Copy link
Member Author

@gabriel-peze I made a rebase and MAYBE I break what you did here: 5cf27f1
Can we confirm together that everything is fine ?


private final InjectExecutionResultService injectExecutionService;

@GetMapping(INJECT_EXECUTION_URI + "/payload_result")
Copy link
Contributor

@savacano28 savacano28 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: We prefer this format (guidelines): /payload-result

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well seen, I forget this one.

@gabriel-peze
Copy link
Contributor

Hey @RomuDeuxfois
In response of this message.

Apparently everything is ok on your branch.

image

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.08%. Comparing base (35befa4) to head (6028ee3).

Files with missing lines Patch % Lines
...naev/rest/inject/InjectExecutionResultService.java 8.33% 11 Missing ⚠️
...enaev/rest/inject/service/InjectStatusService.java 0.00% 4 Missing ⚠️
.../openaev/rest/inject/InjectExecutionResultApi.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #4447      +/-   ##
=====================================================
- Coverage              50.11%   50.08%   -0.04%     
- Complexity              3636     3639       +3     
=====================================================
  Files                    896      898       +2     
  Lines                  26560    26576      +16     
  Branches                1989     1989              
=====================================================
  Hits                   13311    13311              
- Misses                 12450    12466      +16     
  Partials                 799      799              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants