Skip to content

Commit 4b2abdf

Browse files
authored
fix: fix dev container failing to build (#21218)
The dev container fails to build because of the outdated docker-in-docker feature. This updates the docker-in-docker and fixes the build. I also updated the docker compose references in the docs.
1 parent 2010c2a commit 4b2abdf

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

.devcontainer/devcontainer.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,9 @@
1111
},
1212
"ghcr.io/devcontainers/features/rust:1": {},
1313
"ghcr.io/snebjorn/devcontainer-feature/chromium:latest": {},
14-
"docker-in-docker": {
14+
"ghcr.io/devcontainers/features/docker-in-docker:2": {
1515
"version": "latest",
16-
"moby": true,
17-
"dockerDashComposeVersion": "v1"
16+
"moby": true
1817
}
1918
},
2019
// Configure tool-specific properties.

modules/openapi-generator/src/main/resources/python-fastapi/README.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ and open your browser at `http://localhost:{{serverPort}}/docs/` to see the docs
2929
To run the server on a Docker container, please execute the following from the root directory:
3030

3131
```bash
32-
docker-compose up --build
32+
docker compose up --build
3333
```
3434

3535
## Tests

samples/server/petstore/python-fastapi/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ and open your browser at `http://localhost:8080/docs/` to see the docs.
2626
To run the server on a Docker container, please execute the following from the root directory:
2727

2828
```bash
29-
docker-compose up --build
29+
docker compose up --build
3030
```
3131

3232
## Tests

0 commit comments

Comments
 (0)