Skip to content

Commit 592c262

Browse files
Set default value for isOauth field (#22162)
1 parent 40b9d69 commit 592c262

File tree

3 files changed

+36
-1
lines changed

3 files changed

+36
-1
lines changed

modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5734,7 +5734,7 @@ private CodegenSecurity defaultCodegenSecurity(String key, SecurityScheme securi
57345734
cs.name = key;
57355735
cs.description = securityScheme.getDescription();
57365736
cs.type = securityScheme.getType().toString();
5737-
cs.isCode = cs.isPassword = cs.isApplication = cs.isImplicit = cs.isOpenId = false;
5737+
cs.isCode = cs.isPassword = cs.isApplication = cs.isImplicit = cs.isOpenId = cs.isOAuth = false;
57385738
cs.isHttpSignature = false;
57395739
cs.isBasicBasic = cs.isBasicBearer = false;
57405740
cs.scheme = securityScheme.getScheme();

modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5036,6 +5036,19 @@ public void testQueryIsJsonMimeType() {
50365036
assertTrue(codegenOperation.queryParams.stream().allMatch(p -> p.queryIsJsonMimeType));
50375037
}
50385038

5039+
@Test
5040+
public void testDefaultOauthIsNotNull() {
5041+
final DefaultCodegen codegen = new DefaultCodegen();
5042+
final OpenAPI openAPI = TestUtils.parseFlattenSpec("src/test/resources/3_1/issue_20662.yaml");
5043+
codegen.setOpenAPI(openAPI);
5044+
List<CodegenSecurity> securitySchemes = codegen.fromSecurity(openAPI.getComponents().getSecuritySchemes());
5045+
assertThat(securitySchemes.size()).isEqualTo(1);
5046+
CodegenSecurity openIdScheme = securitySchemes.get(0);
5047+
assertNotNull(openIdScheme.isOAuth);
5048+
assertFalse(openIdScheme.isOAuth);
5049+
assertTrue(openIdScheme.isOpenId);
5050+
}
5051+
50395052
private List<String> getRequiredVars(CodegenModel model) {
50405053
return getNames(model.getRequiredVars());
50415054
}
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
openapi: 3.1.0
2+
info:
3+
title: Security scheme test
4+
version: 1.0.0
5+
paths:
6+
/test:
7+
get:
8+
responses:
9+
'200':
10+
description: successful operation
11+
content:
12+
application/json:
13+
schema:
14+
type: string
15+
components:
16+
securitySchemes:
17+
openId:
18+
type: openIdConnect
19+
openIdConnectUrl: https://localhost:8443
20+
security:
21+
- openId:
22+
- test

0 commit comments

Comments
 (0)