Skip to content

Commit 7074250

Browse files
committed
test(gdscript): test the delete operation as well
/spend 7m
1 parent acede28 commit 7074250

File tree

3 files changed

+34
-14
lines changed

3 files changed

+34
-14
lines changed

samples/client/petstore/gdscript/addons/gut/gui/GutSceneTheme.tres

Lines changed: 4 additions & 4 deletions
Large diffs are not rendered by default.

samples/client/petstore/gdscript/addons/oas.petstore.client/core/DemoApiBee.gd

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,8 @@ func _bzz_request(
175175
var error := DemoApiError.new()
176176
error.internal_code = parsing
177177
error.identifier = "apibee.decode.cannot_parse_json"
178+
error.response_code = response.code
179+
error.response = response
178180
error.message = "%s: failed to parse JSON response at line %d.\n%s" % [
179181
_bzz_name, parser.get_error_line(), parser.get_error_message()
180182
]
@@ -185,6 +187,8 @@ func _bzz_request(
185187
var error := DemoApiError.new()
186188
error.internal_code = ERR_INVALID_DATA
187189
error.identifier = "apibee.decode.mime_type_unsupported"
190+
error.response_code = response.code
191+
error.response = response
188192
error.message = "%s: mime type `%s' is not supported (yet -- MRs welcome)" % [
189193
_bzz_name, mime
190194
]
@@ -350,6 +354,7 @@ func _bzz_do_request_text(
350354
var error := DemoApiError.new()
351355
error.internal_code = ERR_PRINTER_ON_FIRE
352356
error.response_code = response.code
357+
error.response = response
353358
error.identifier = "apibee.response.5xx"
354359
error.message = "%s: request to `%s' made the server hiccup with a %d." % [
355360
_bzz_name, path, response.code
@@ -363,6 +368,7 @@ func _bzz_do_request_text(
363368
var error := DemoApiError.new()
364369
error.identifier = "apibee.response.4xx"
365370
error.response_code = response.code
371+
error.response = response
366372
error.message = "%s: request to `%s' was denied with a %d." % [
367373
_bzz_name, path, response.code
368374
]
@@ -375,6 +381,7 @@ func _bzz_do_request_text(
375381
var error := DemoApiError.new()
376382
error.identifier = "apibee.response.3xx"
377383
error.response_code = response.code
384+
error.response = response
378385
error.message = "%s: request to `%s' was redirected with a %d. We do not support redirects in that client yet." % [
379386
_bzz_name, path, response.code
380387
]

samples/client/petstore/gdscript/test/integration/test_basic.gd

Lines changed: 23 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,12 @@ func before_all():
1818
configure()
1919

2020

21-
func fail_test(msg=""):
21+
func fail_test(msg:=""):
2222
super.fail_test(msg)
2323
emit_signal("test_ended")
2424

2525

2626
func test_authenticated_user_uses_monkey_crud():
27-
#gut.p("Running test 01…")
2827

2928
var rick := DemoUserModel.new()
3029
rick.username = "Rick"
@@ -42,8 +41,12 @@ func test_authenticated_user_uses_monkey_crud():
4241
func(monkey):
4342
update_monkey(
4443
monkey, "Summer",
45-
func(_result):
46-
emit_signal("test_ended")
44+
func(_updated_monkey):
45+
delete_monkey(
46+
monkey.id,
47+
func(_what):
48+
emit_signal("test_ended")
49+
)
4750
)
4851
)
4952
)
@@ -112,13 +115,23 @@ func update_monkey(monkey, new_name, on_done: Callable):
112115
# assert_eq(result.code, 200)
113116
on_done.call(result.data)
114117
,
115-
#func(error: ApiError): # ← straight up crash, try again later
116118
func(error):
117-
# OH GOSH THIS CRASHES AS WELL (works with RefCounted)
118-
# (but error does have type ApiError)
119-
# if not (error is ApiError):
120-
# fail("Error in on_failure callback has the wrong type.")
121-
printerr("ERROR!")
119+
fail_test(str(error))
120+
,
121+
)
122+
123+
124+
func delete_monkey(monkey_id, on_done: Callable):
125+
126+
var pet_api := DemoPetApi.new(cfg)
127+
pet_api.delete_pet(
128+
monkey_id, "whyisapikeyhere",
129+
func(response):
130+
prints("Deleted monkey:", response)
131+
assert_eq(response.code, 200)
132+
on_done.call(response)
133+
,
134+
func(error):
122135
fail_test(str(error))
123136
,
124137
)

0 commit comments

Comments
 (0)