Skip to content

Commit 9a289e9

Browse files
authored
adjust jersey2/jersey3 templates (#21171)
* respect useJakartaEE in jersey3 * useJakarteEE=true in jersey3 samples * don't force jakarta package for jersey3 * adjust whitespace between jersey2 and jersey3 * enforce useJakartaEe for jersey3, warn on misuse for jersey 2 * set useJakartaEe for jersey3, generate samples
1 parent 3fadfe3 commit 9a289e9

File tree

21 files changed

+29
-22
lines changed

21 files changed

+29
-22
lines changed

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JavaClientCodegen.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,9 @@ public void processOpts() {
587587
// The flag below should be set for all Java libraries, but the templates need to be ported
588588
// one by one for each library.
589589
supportsAdditionalPropertiesWithComposedSchema = true;
590+
if (useJakartaEe) {
591+
LOGGER.warn("Jersey 2 is not compatible with Jakarta EE. Please use Jersey 3 or set {} to false.", USE_JAKARTA_EE);
592+
}
590593
} else if (libJersey3) {
591594
additionalProperties.put("jersey3", true);
592595
supportingFiles.add(new SupportingFile("JSON.mustache", invokerFolder, "JSON.java"));
@@ -603,6 +606,7 @@ public void processOpts() {
603606
// The flag below should be set for all Java libraries, but the templates need to be ported
604607
// one by one for each library.
605608
supportsAdditionalPropertiesWithComposedSchema = true;
609+
setUseJakartaEe(true);
606610
applyJakartaPackage();
607611
} else if (libNative) {
608612
supportingFiles.add(new SupportingFile("ApiResponse.mustache", invokerFolder, "ApiResponse.java"));

modules/openapi-generator/src/main/resources/Java/libraries/jersey2/ApiClient.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1021,7 +1021,7 @@ public class ApiClient{{#jsr310}} extends JavaTimeFormatter{{/jsr310}} {
10211021
return entity;
10221022
}
10231023

1024-
/**
1024+
/**
10251025
* Adds the object with the provided key to the MultiPart.
10261026
* Based on the object type sets Content-Disposition and Content-Type.
10271027
*

modules/openapi-generator/src/main/resources/Java/libraries/jersey3/ApiClient.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1386,7 +1386,7 @@ public class ApiClient{{#jsr310}} extends JavaTimeFormatter{{/jsr310}} {
13861386
protected Client buildHttpClient() {
13871387
// Create ClientConfig if it has not been initialized yet
13881388
if (clientConfig == null) {
1389-
clientConfig = getDefaultClientConfig();
1389+
clientConfig = getDefaultClientConfig();
13901390
}
13911391

13921392
ClientBuilder clientBuilder = ClientBuilder.newBuilder();

modules/openapi-generator/src/main/resources/Java/libraries/jersey3/api.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ import {{javaxPackage}}.ws.rs.core.GenericType;
1212
{{/imports}}
1313

1414
{{#useBeanValidation}}
15-
import jakarta.validation.constraints.*;
16-
import jakarta.validation.Valid;
15+
import {{javaxPackage}}.validation.constraints.*;
16+
import {{javaxPackage}}.validation.Valid;
1717

1818
{{/useBeanValidation}}
1919
import java.util.ArrayList;

modules/openapi-generator/src/main/resources/Java/libraries/jersey3/api_test.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ import java.util.List;
1717
import java.util.Map;
1818

1919
{{#useBeanValidation}}
20-
import jakarta.validation.constraints.*;
21-
import jakarta.validation.Valid;
20+
import {{javaxPackage}}.validation.constraints.*;
21+
import {{javaxPackage}}.validation.Valid;
2222

2323
{{/useBeanValidation}}
2424
/**

modules/openapi-generator/src/main/resources/Java/libraries/jersey3/build.gradle.mustache

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ dependencies {
152152
{{#useReflectionEqualsHashCode}}
153153
implementation "org.apache.commons:commons-lang3:$commons_lang3_version"
154154
{{/useReflectionEqualsHashCode}}
155-
156155
testImplementation "org.junit.jupiter:junit-jupiter-api:$junit_version"
157156
testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:$junit_version"
158157
}

modules/openapi-generator/src/main/resources/Java/libraries/jersey3/model.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ import android.os.Parcelable;
4242
import android.os.Parcel;
4343
{{/parcelableModel}}
4444
{{#useBeanValidation}}
45-
import jakarta.validation.constraints.*;
46-
import jakarta.validation.Valid;
45+
import {{javaxPackage}}.validation.constraints.*;
46+
import {{javaxPackage}}.validation.Valid;
4747
{{/useBeanValidation}}
4848
{{#performBeanValidation}}
4949
import org.hibernate.validator.constraints.*;

modules/openapi-generator/src/main/resources/Java/libraries/jersey3/pom.mustache

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,8 +408,14 @@
408408
<jackson-version>2.17.1</jackson-version>
409409
<jackson-databind-version>2.17.1</jackson-databind-version>
410410
<jackson-databind-nullable-version>0.2.6</jackson-databind-nullable-version>
411+
{{#useJakartaEe}}
411412
<jakarta-annotation-version>2.1.1</jakarta-annotation-version>
412413
<beanvalidation-version>3.0.2</beanvalidation-version>
414+
{{/useJakartaEe}}
415+
{{^useJakartaEe}}
416+
<jakarta-annotation-version>1.3.5</jakarta-annotation-version>
417+
<beanvalidation-version>2.0.2</beanvalidation-version>
418+
{{/useJakartaEe}}
413419
<junit-version>5.10.0</junit-version>
414420
{{#hasHttpSignatureMethods}}
415421
<http-signature-version>1.8</http-signature-version>

samples/client/others/java/jersey2-oneOf-Mixed/src/main/java/org/openapitools/client/ApiClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -800,7 +800,7 @@ public Entity<?> serialize(Object obj, Map<String, Object> formParams, String co
800800
return entity;
801801
}
802802

803-
/**
803+
/**
804804
* Adds the object with the provided key to the MultiPart.
805805
* Based on the object type sets Content-Disposition and Content-Type.
806806
*

samples/client/others/java/jersey2-oneOf-duplicates/src/main/java/org/openapitools/client/ApiClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -800,7 +800,7 @@ public Entity<?> serialize(Object obj, Map<String, Object> formParams, String co
800800
return entity;
801801
}
802802

803-
/**
803+
/**
804804
* Adds the object with the provided key to the MultiPart.
805805
* Based on the object type sets Content-Disposition and Content-Type.
806806
*

0 commit comments

Comments
 (0)