typescript-fetch: Fix model date crash (#21821)

* typescript-fetch: Fix model date crash

Fix a runtime crash converting to json when a date or datetime is both nullable
AND required. There are 4 cases to account for:

| required | nullable | values |
|----------|----------|--------|
| f        | f        | string OR undefined |
| f        | t        | string OR null OR undefined |
| t        | f        | string |
| t        | t        | string OR null |

And importantly when required and nullable code that would crash on null was
being generated. additionally when required is false and nullable is true we
still want to allow consumers to be able to pass in `undefined` OR `null` and
pass that value to the server. Some servers treat null and undefined differently
for some operations so having that ability is pretty reasonable.

fix: #21820

* Update typescript-fetch samples

./bin/generate-samples.sh ./bin/configs/*.yaml || exit

Author: kradical

modules/openapi-generator/src/main/resources/typescript-fetch/modelGeneric.mustache

@@ -141,10 +141,10 @@ export function {{classname}}ToJSONTyped(value?: {{#hasReadOnly}}Omit<{{classnam
         {{^isReadOnly}}
         {{#isPrimitiveType}}
         {{#isDateType}}
-        '{{baseName}}': {{^required}}{{#isNullable}}value['{{name}}'] === null ? null : {{/isNullable}}{{^isNullable}}value['{{name}}'] == null ? undefined : {{/isNullable}}{{/required}}((value['{{name}}']{{#isNullable}} as any{{/isNullable}}){{^required}}{{#isNullable}}?{{/isNullable}}{{/required}}.toISOString().substring(0,10)),
+        '{{baseName}}': {{^required}}value['{{name}}'] == null ? value['{{name}}'] : {{/required}}{{#isNullable}}{{#required}}value['{{name}}'] == null ? value['{{name}}'] : {{/required}}{{/isNullable}}value['{{name}}'].toISOString().substring(0,10),
         {{/isDateType}}
         {{#isDateTimeType}}
-        '{{baseName}}': {{^required}}{{#isNullable}}value['{{name}}'] === null ? null : {{/isNullable}}{{^isNullable}}value['{{name}}'] == null ? undefined : {{/isNullable}}{{/required}}((value['{{name}}']{{#isNullable}} as any{{/isNullable}}){{^required}}{{#isNullable}}?{{/isNullable}}{{/required}}.toISOString()),
+        '{{baseName}}': {{^required}}value['{{name}}'] == null ? value['{{name}}'] : {{/required}}{{#isNullable}}{{#required}}value['{{name}}'] == null ? value['{{name}}'] : {{/required}}{{/isNullable}}value['{{name}}'].toISOString(),
         {{/isDateTimeType}}
         {{#isArray}}
         '{{baseName}}': {{#uniqueItems}}{{^required}}value['{{name}}'] == null ? undefined : {{/required}}{{#required}}{{#isNullable}}value['{{name}}'] == null ? null : {{/isNullable}}{{/required}}Array.from(value['{{name}}'] as Set<any>){{/uniqueItems}}{{^uniqueItems}}value['{{name}}']{{/uniqueItems}},

samples/client/petstore/typescript-fetch/builds/default-v3.0/models/FormatTest.ts

@@ -178,8 +178,8 @@ export function FormatTestToJSONTyped(value?: FormatTest | null, ignoreDiscrimin
         'string': value['string'],
         'byte': value['_byte'],
         'binary': value['binary'],
-        'date': ((value['date']).toISOString().substring(0,10)),
-        'dateTime': value['dateTime'] == null ? undefined : ((value['dateTime']).toISOString()),
+        'date': value['date'].toISOString().substring(0,10),
+        'dateTime': value['dateTime'] == null ? value['dateTime'] : value['dateTime'].toISOString(),
         'uuid': value['uuid'],
         'password': value['password'],
         'pattern_with_digits': value['patternWithDigits'],

samples/client/petstore/typescript-fetch/builds/default-v3.0/models/MixedPropertiesAndAdditionalPropertiesClass.ts

@@ -82,7 +82,7 @@ export function MixedPropertiesAndAdditionalPropertiesClassToJSONTyped(value?: M
     return {
 
         'uuid': value['uuid'],
-        'dateTime': value['dateTime'] == null ? undefined : ((value['dateTime']).toISOString()),
+        'dateTime': value['dateTime'] == null ? value['dateTime'] : value['dateTime'].toISOString(),
         'map': value['map'] == null ? undefined : (mapValues(value['map'], AnimalToJSON)),
     };
 }

samples/client/petstore/typescript-fetch/builds/default-v3.0/models/NullableClass.ts

@@ -143,8 +143,8 @@ export function NullableClassToJSONTyped(value?: NullableClass | null, ignoreDis
         'number_prop': value['numberProp'],
         'boolean_prop': value['booleanProp'],
         'string_prop': value['stringProp'],
-        'date_prop': value['dateProp'] === null ? null : ((value['dateProp'] as any)?.toISOString().substring(0,10)),
-        'datetime_prop': value['datetimeProp'] === null ? null : ((value['datetimeProp'] as any)?.toISOString()),
+        'date_prop': value['dateProp'] == null ? value['dateProp'] : value['dateProp'].toISOString().substring(0,10),
+        'datetime_prop': value['datetimeProp'] == null ? value['datetimeProp'] : value['datetimeProp'].toISOString(),
         'array_nullable_prop': value['arrayNullableProp'],
         'array_and_items_nullable_prop': value['arrayAndItemsNullableProp'],
         'array_items_nullable': value['arrayItemsNullable'],

samples/client/petstore/typescript-fetch/builds/default-v3.0/models/Order.ts

@@ -109,7 +109,7 @@ export function OrderToJSONTyped(value?: Order | null, ignoreDiscriminator: bool
         'id': value['id'],
         'petId': value['petId'],
         'quantity': value['quantity'],
-        'shipDate': value['shipDate'] == null ? undefined : ((value['shipDate']).toISOString()),
+        'shipDate': value['shipDate'] == null ? value['shipDate'] : value['shipDate'].toISOString(),
         'status': value['status'],
         'complete': value['complete'],
     };

samples/client/petstore/typescript-fetch/builds/default/models/Order.ts

@@ -109,7 +109,7 @@ export function OrderToJSONTyped(value?: Order | null, ignoreDiscriminator: bool
         'id': value['id'],
         'petId': value['petId'],
         'quantity': value['quantity'],
-        'shipDate': value['shipDate'] == null ? undefined : ((value['shipDate']).toISOString()),
+        'shipDate': value['shipDate'] == null ? value['shipDate'] : value['shipDate'].toISOString(),
         'status': value['status'],
         'complete': value['complete'],
     };

samples/client/petstore/typescript-fetch/builds/es6-target/src/models/Order.ts

@@ -109,7 +109,7 @@ export function OrderToJSONTyped(value?: Order | null, ignoreDiscriminator: bool
         'id': value['id'],
         'petId': value['petId'],
         'quantity': value['quantity'],
-        'shipDate': value['shipDate'] == null ? undefined : ((value['shipDate']).toISOString()),
+        'shipDate': value['shipDate'] == null ? value['shipDate'] : value['shipDate'].toISOString(),
         'status': value['status'],
         'complete': value['complete'],
     };

samples/client/petstore/typescript-fetch/builds/multiple-parameters/models/Order.ts

@@ -109,7 +109,7 @@ export function OrderToJSONTyped(value?: Order | null, ignoreDiscriminator: bool
         'id': value['id'],
         'petId': value['petId'],
         'quantity': value['quantity'],
-        'shipDate': value['shipDate'] == null ? undefined : ((value['shipDate']).toISOString()),
+        'shipDate': value['shipDate'] == null ? value['shipDate'] : value['shipDate'].toISOString(),
         'status': value['status'],
         'complete': value['complete'],
     };

samples/client/petstore/typescript-fetch/builds/prefix-parameter-interfaces/src/models/Order.ts

@@ -109,7 +109,7 @@ export function OrderToJSONTyped(value?: Order | null, ignoreDiscriminator: bool
         'id': value['id'],
         'petId': value['petId'],
         'quantity': value['quantity'],
-        'shipDate': value['shipDate'] == null ? undefined : ((value['shipDate']).toISOString()),
+        'shipDate': value['shipDate'] == null ? value['shipDate'] : value['shipDate'].toISOString(),
         'status': value['status'],
         'complete': value['complete'],
     };

samples/client/petstore/typescript-fetch/builds/sagas-and-records/src/models/Order.ts

@@ -109,7 +109,7 @@ export function OrderToJSONTyped(value?: Order | null, ignoreDiscriminator: bool
         'id': value['id'],
         'petId': value['petId'],
         'quantity': value['quantity'],
-        'shipDate': value['shipDate'] == null ? undefined : ((value['shipDate']).toISOString()),
+        'shipDate': value['shipDate'] == null ? value['shipDate'] : value['shipDate'].toISOString(),
         'status': value['status'],
         'complete': value['complete'],
     };