Skip to content

Conversation

@n-rodriguez
Copy link
Contributor

@n-rodriguez n-rodriguez commented Dec 22, 2025

Fix #22563

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@n-rodriguez n-rodriguez changed the title Fix/reserved words [CRYSTAL] object_id method should be a reserved words Dec 22, 2025
@n-rodriguez
Copy link
Contributor Author

n-rodriguez commented Dec 24, 2025

@n-rodriguez
Copy link
Contributor Author

n-rodriguez commented Dec 24, 2025

Also the Pet store sample is a bit light to exercise all the models : for instance no AnyOf module/class is generated 😢

Maybe using a subset of Netbox API / schema (which is a real world example) would help to better test the generator?

Merry Christmas! 🎅

Fix:
-  class EnumAttributeValidatorFor_type < EnumAttributeValidator
+  class EnumAttributeValidatorForType < EnumAttributeValidator
@wing328
Copy link
Member

wing328 commented Jan 13, 2026

Also the Pet store sample is a bit light to exercise all the models : for instance no AnyOf module/class is generated 😢

what about updating modules/openapi-generator/src/test/resources/3_0/crystal/petstore.yaml with additional test schemas with anyOf, oneOf, etc?

@@ -1,8 +0,0 @@
# {{#lambdaPrefixWithHash}}{{> api_info}}{{/lambdaPrefixWithHash}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mind removing travis support (if someone needs it, we can always add it back) but what about adding github workflow for example as a replacement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that in a next PR

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. let's give it a try

@wing328 wing328 merged commit a40dc56 into OpenAPITools:master Jan 13, 2026
16 checks passed
@wing328 wing328 added this to the 7.19.0 milestone Jan 13, 2026
@n-rodriguez
Copy link
Contributor Author

what about updating modules/openapi-generator/src/test/resources/3_0/crystal/petstore.yaml with additional test schemas with anyOf, oneOf, etc?

I'll give it a look. Thank you!

@n-rodriguez n-rodriguez deleted the fix/reserved_words branch January 13, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Crystal] The current Crystal generator generates code with wrongly typed variables.

2 participants