[R] remove nuisance DUMMY_ENUM warning #22692
Open
+0
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ramanth, @saigiridhar21, @wing328
This PR removes an annoying warning. Since generated models are used when parsing REST responses into R6 objects for the R language client, the
". If you did not manually initialize {{{classname}}}, this may already be overwritten by an enum loaded from a JSON config."part of the warning is usually true, meaning that any responses that include enums will invariably print confusing warning messages.I left the check to ensure that the enum is populated either with an acceptable value or
DUMMY_ENUMso that JSON parsing continues to work in the same way it currently does.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Removed the DUMMY_ENUM initialization warning in R enum models to stop confusing messages when parsing API responses. Validation still enforces allowed values, and the DUMMY_ENUM fallback behavior is unchanged.
Written for commit 679b8ff. Summary will update on new commits.