fix(get_audio_info, visualize): replace use of recording timestamp in functions with recording id (#717)

* fix(audio): Replace use of recording timestamp in functions with recording id (#727)

Co-authored-by: Shohan Dutta Roy <[email protected]>

* fix get_audio_info

* black

---------

Co-authored-by: Shohan Dutta Roy <[email protected]>

Author: abrichr

openadapt/app/dashboard/api/recordings.py

@@ -83,8 +83,7 @@ async def get_recording_detail(websocket: WebSocket, recording_id: int) -> None:
             )
 
             try:
-                # TODO: change to use recording_id once scrubbing PR is merged
-                audio_info = crud.get_audio_info(session, recording.timestamp)[0]
+                audio_info = crud.get_audio_info(session, recording)
                 words_with_timestamps = json.loads(audio_info.words_with_timestamps)
                 words_with_timestamps = [
                     {

openadapt/db/crud.py

@@ -675,21 +675,21 @@ def insert_audio_info(
     session.commit()
 
 
-# TODO: change to use recording_id once scrubbing PR is merged
 def get_audio_info(
     session: SaSession,
-    recording_timestamp: float,
-) -> list[AudioInfo]:
+    recording: Recording,
+) -> AudioInfo:
     """Get the audio info for a given recording.
 
     Args:
         session (sa.orm.Session): The database session.
-        recording_timestamp (float): The timestamp of the recording.
+        recording (Recording): The recording object.
 
     Returns:
-        list[AudioInfo]: A list of audio info for the recording.
+        AudioInfo: Audio info for the recording.
     """
-    return _get(session, AudioInfo, recording_timestamp)
+    audio_infos = _get(session, AudioInfo, recording.id)
+    return audio_infos[0] if audio_infos else None
 
 
 def post_process_events(session: SaSession, recording: Recording) -> None:

openadapt/utils.py

@@ -98,6 +98,8 @@ def row2dict(row: dict | db.BaseModel, follow: bool = True) -> dict:
     Returns:
         dict: The row object converted to a dictionary.
     """
+    if not row:
+        return {}
     if isinstance(row, dict):
         return row
     try_follow = ["children"] if follow else []

openadapt/visualize.py

@@ -186,9 +186,11 @@ def main(
     logger.info(f"{recording=}")
     logger.info(f"{diff_video=}")
 
-    audio_info = row2dict(crud.get_audio_info(recording))
-    # don't display the FLAC data
-    del audio_info["flac_data"]
+    session = crud.get_new_session(read_only=True)
+    audio_info = row2dict(crud.get_audio_info(session, recording))
+    if audio_info:
+        del audio_info["flac_data"]
+    # TODO XXX: display audio_info
 
     if diff_video:
         assert recording.config[