Skip to content

Commit 6bf1ee6

Browse files
freeeyesfreeeyes
committed
fix code smell.
1 parent b100068 commit 6bf1ee6

File tree

4 files changed

+26
-25
lines changed

4 files changed

+26
-25
lines changed

‎.github/workflows/PSS_ASIO.yml‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -82,28 +82,28 @@ jobs:
8282
ls -l coverage.info
8383
echo "[lcov]********************End"
8484
85-
echo "gcov********************"
86-
cd ${{github.workspace}}
87-
pwd
88-
gcovr --sonarqube > coverage.xml
89-
ls -la coverage.xml
90-
echo "gcov********************Begin"
91-
# cd ${{github.workspace}}/Build/Linux/
85+
# echo "gcov********************"
86+
# cd ${{github.workspace}}
9287
# pwd
93-
# ls -l ./PSS_ASIO/CMakeFiles/pss_asio.dir/QueueSession/
94-
# echo "gcov********************(gcda)"
95-
# ls -l ./PSS_ASIO/CMakeFiles/pss_asio.dir/QueueSession/*.gcda
96-
# echo "gcov********************(gcc --version)"
97-
# gcc --version
98-
# echo "gcov********************end"
99-
# gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/QueueSession/*.cpp.gcda ../../PSS_ASIO/QueueSession/*.cpp > /dev/null
100-
# gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/TTySession/*.cpp.gcda ../../PSS_ASIO/TTySession/*.cpp > /dev/null
101-
# gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/TcpSession/*.cpp.gcda ../../PSS_ASIO/TcpSession/*.cpp > /dev/null
102-
# gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/UdpSession/*.cpp.gcda ../../PSS_ASIO/UdpSession/*.cpp > /dev/null
103-
# gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/Common/*.cpp.gcda ../../PSS_ASIO/Common/*.cpp > /dev/null
104-
# gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/Message/*.cpp.gcda ../../PSS_ASIO/Message/*.cpp > /dev/null
105-
# find ./ -name "*.gcov" | wc -l
106-
# echo "gcov********************End"
88+
# gcovr --sonarqube > coverage.xml
89+
# ls -la coverage.xml
90+
echo "gcov********************Begin"
91+
cd ${{github.workspace}}/Build/Linux/
92+
pwd
93+
ls -l ./PSS_ASIO/CMakeFiles/pss_asio.dir/QueueSession/
94+
echo "gcov********************(gcda)"
95+
ls -l ./PSS_ASIO/CMakeFiles/pss_asio.dir/QueueSession/*.gcda
96+
echo "gcov********************(gcc --version)"
97+
gcc --version
98+
echo "gcov*********************(sonar begin)"
99+
gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/QueueSession/*.cpp.gcda ../../PSS_ASIO/QueueSession/*.cpp > /dev/null
100+
gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/TTySession/*.cpp.gcda ../../PSS_ASIO/TTySession/*.cpp > /dev/null
101+
gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/TcpSession/*.cpp.gcda ../../PSS_ASIO/TcpSession/*.cpp > /dev/null
102+
gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/UdpSession/*.cpp.gcda ../../PSS_ASIO/UdpSession/*.cpp > /dev/null
103+
gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/Common/*.cpp.gcda ../../PSS_ASIO/Common/*.cpp > /dev/null
104+
gcov -a ./PSS_ASIO/CMakeFiles/pss_asio.dir/Message/*.cpp.gcda ../../PSS_ASIO/Message/*.cpp > /dev/null
105+
find ./ -name "*.gcov" | wc -l
106+
echo "gcov********************End"
107107
108108
109109
- name: SonarCloud Scan make report

‎PSS_ASIO/Message/ModuleLogic.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ int CWorkThreadLogic::assignation_thread_module_logic(const uint32 connect_id, v
433433
{
434434
//判断有没有需要同步处理的消息
435435
CMessage_Source source;
436-
std::shared_ptr<CMessage_Packet> send_packet = std::make_shared<CMessage_Packet>();
436+
auto send_packet = std::make_shared<CMessage_Packet>();
437437

438438
source.connect_id_ = connect_id;
439439
source.type_ = session->get_io_type();

‎PSS_ASIO/Message/SyncLogic.cpp‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
void CSyncLogic::Close()
44
{
5+
command_to_session_function_.clear();
56
}
67

78
void CSyncLogic::Init(const command_to_module_function& command_to_module_function)
@@ -10,7 +11,7 @@ void CSyncLogic::Init(const command_to_module_function& command_to_module_functi
1011
command_to_session_function_ = command_to_module_function;
1112
}
1213

13-
void CSyncLogic::do_sync_message_list(CMessage_Source& source, vector<std::shared_ptr<CMessage_Packet>>& message_list, std::shared_ptr<CMessage_Packet> send_packet)
14+
void CSyncLogic::do_sync_message_list(CMessage_Source& source, vector<std::shared_ptr<CMessage_Packet>>& message_list, std::shared_ptr<CMessage_Packet> send_packet) const
1415
{
1516
if (command_to_session_function_.size() == 0)
1617
{
@@ -23,7 +24,7 @@ void CSyncLogic::do_sync_message_list(CMessage_Source& source, vector<std::share
2324
std::remove_if(
2425
message_list.begin(),
2526
message_list.end(),
26-
[source, send_packet](const std::shared_ptr<CMessage_Packet>& packet) {
27+
[&source, &send_packet](const std::shared_ptr<CMessage_Packet>& packet) {
2728
return App_SyncLogic::instance()->do_sync_message(packet->command_id_, source, packet, send_packet);
2829
}
2930
),

‎PSS_ASIO/Message/SyncLogic.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class CSyncLogic
1717

1818
void Init(const command_to_module_function& command_to_module_function);
1919

20-
void do_sync_message_list(CMessage_Source& source, vector<std::shared_ptr<CMessage_Packet>>& message_list, std::shared_ptr<CMessage_Packet> send_packet);
20+
void do_sync_message_list(CMessage_Source& source, vector<std::shared_ptr<CMessage_Packet>>& message_list, std::shared_ptr<CMessage_Packet> send_packet) const;
2121

2222
bool do_sync_message(const uint16 command_id, const CMessage_Source& source, std::shared_ptr<CMessage_Packet> recv_packet, std::shared_ptr<CMessage_Packet> send_packet);
2323

0 commit comments

Comments
 (0)