You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Set up ruff to enforce a 99 char line limit, mirroring other OpenAssetIO
projects.
Configure yml with 2-space tabs, mirroring other OpenAssetIO projects
(and the ComfyUI cookiecutter project's defaults).
Bulk reformat using PyCharm configured to use ruff - i.e. Python files
are reformatted using ruff, whilst other files are reformatted
according to .editorconfig and/or PyCharm defaults.
Signed-off-by: David Feltell <[email protected]>
Copy file name to clipboardExpand all lines: README.md
+34-13Lines changed: 34 additions & 13 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -3,13 +3,17 @@
3
3
OpenAssetIO ingress and egress
4
4
5
5
> [!NOTE]
6
-
> This projected was created with a [cookiecutter](https://github.com/Comfy-Org/cookiecutter-comfy-extension) template. It helps you start writing custom nodes without worrying about the Python setup.
6
+
> This projected was created with
7
+
> a [cookiecutter](https://github.com/Comfy-Org/cookiecutter-comfy-extension) template. It helps you
8
+
> start
9
+
> writing custom nodes without worrying about the Python setup.
1. Look up this extension in ComfyUI-Manager. If you are installing manually, clone this repository under `ComfyUI/custom_nodes`.
15
+
1. Look up this extension in ComfyUI-Manager. If you are installing manually, clone this repository
16
+
under `ComfyUI/custom_nodes`.
13
17
1. Restart ComfyUI.
14
18
15
19
# Features
@@ -26,14 +30,19 @@ pip install -e .[dev]
26
30
pre-commit install
27
31
```
28
32
29
-
The `-e` flag above will result in a "live" install, in the sense that any changes you make to your node extension will automatically be picked up the next time you run ComfyUI.
33
+
The `-e` flag above will result in a "live" install, in the sense that any changes you make to your
34
+
node extension will automatically be
35
+
picked up the next time you run ComfyUI.
30
36
31
37
## Publish to Github
32
38
33
-
Install Github Desktop or follow these [instructions](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent) for ssh.
39
+
Install Github Desktop or follow
40
+
these [instructions](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent)
41
+
for ssh.
34
42
35
43
1. Create a Github repository that matches the directory name.
36
44
2. Push the files to Git
45
+
37
46
```
38
47
git add .
39
48
git commit -m "project scaffolding"
@@ -42,26 +51,38 @@ git push
42
51
43
52
## Writing custom nodes
44
53
45
-
An example custom node is located in [node.py](src/openassetio-comfyui/nodes.py). To learn more, read the [docs](https://docs.comfy.org/essentials/custom_node_overview).
46
-
54
+
An example custom node is located in [node.py](src/openassetio-comfyui/nodes.py). To learn more,
55
+
read
56
+
the [docs](https://docs.comfy.org/essentials/custom_node_overview).
47
57
48
58
## Tests
49
59
50
-
This repo contains unit tests written in Pytest in the `tests/` directory. It is recommended to unit test your custom node.
60
+
This repo contains unit tests written in Pytest in the `tests/` directory. It is recommended to
61
+
unit test your custom node.
51
62
52
-
-[build-pipeline.yml](.github/workflows/build-pipeline.yml) will run pytest and linter on any open PRs
53
-
-[validate.yml](.github/workflows/validate.yml) will run [node-diff](https://github.com/Comfy-Org/node-diff) to check for breaking changes
63
+
-[build-pipeline.yml](.github/workflows/build-pipeline.yml) will run pytest and linter on any open
64
+
PRs
65
+
-[validate.yml](.github/workflows/validate.yml) will
66
+
run [node-diff](https://github.com/Comfy-Org/node-diff) to check for breaking changes
54
67
55
68
## Publishing to Registry
56
69
57
-
If you wish to share this custom node with others in the community, you can publish it to the registry. We've already auto-populated some fields in `pyproject.toml` under `tool.comfy`, but please double-check that they are correct.
70
+
If you wish to share this custom node with others in the community, you can publish it to the
71
+
registry. We've already auto-populated some
72
+
fields in `pyproject.toml` under `tool.comfy`, but please double-check that they are correct.
58
73
59
74
You need to make an account on https://registry.comfy.org and create an API key token.
60
75
61
-
-[ ] Go to the [registry](https://registry.comfy.org). Login and create a publisher id (everything after the `@` sign on your registry profile).
76
+
-[ ] Go to the [registry](https://registry.comfy.org). Login and create a publisher id (everything
77
+
after the `@` sign on your registry
78
+
profile).
62
79
-[ ] Add the publisher id into the pyproject.toml file.
63
-
-[ ] Create an api key on the Registry for publishing from Github. [Instructions](https://docs.comfy.org/registry/publishing#create-an-api-key-for-publishing).
80
+
-[ ] Create an api key on the Registry for publishing from
-[ ] Add it to your Github Repository Secrets as `REGISTRY_ACCESS_TOKEN`.
65
83
66
-
A Github action will run on every git push. You can also run the Github action manually. Full instructions [here](https://docs.comfy.org/registry/publishing). Join our [discord](https://discord.com/invite/comfyorg) if you have any questions!
84
+
A Github action will run on every git push. You can also run the Github action manually. Full
0 commit comments