Skip to content

Commit c9762c1

Browse files
Dont setCurrentIndex on serial port combo
Something got weird and then broke (PySide6-Essentials 6.6.1, 6.6.3) with QComboBox and trying to use the setCurrentIndex slot in another thread gives QBasicTimer::start: Timers cannot be started from another thread QObject::startTimer: Timers cannot be started from another thread errors when selecting the combo box afterwards. This was just a QoL feature so just remove it.
1 parent 2651831 commit c9762c1

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

OATFWGUI/gui_logic.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -361,11 +361,6 @@ def pio_refresh_ports_finished(self):
361361
self.main_app.wCombo_serial_port.clear()
362362
for serial_port in self.logic_state.serial_ports:
363363
self.main_app.wCombo_serial_port.addItem(serial_port)
364-
if len(self.logic_state.serial_ports) > 0:
365-
self.main_app.wCombo_serial_port.setCurrentIndex(0)
366-
else:
367-
self.logic_state.upload_port = None
368-
self.main_app.wCombo_serial_port.setCurrentIndex(-1)
369364

370365
@Slot()
371366
def serial_port_combo_box_changed(self, idx: int):

0 commit comments

Comments
 (0)