some code cleanup

Author: rmisio

js/router.js

@@ -77,17 +77,10 @@ module.exports = Backbone.Router.extend({
         cached = this.viewCache[key];
         if (Date.now() - cached.cachedAt >= cached.view.cacheExpires) {
           delete this.viewCache[key].view.__cachedScrollPos;
-          delete this.viewCache[key].view.__cachedAddressBarText;
           delete this.viewCache[key];
         }
       }      
     }, this.cleanCacheInterval);
-
-    this.listenTo(window.obEventBus, 'addressBarTextSet', (text) => {
-      if (this.view) {
-        this.view.__cachedAddressBarText = text;
-      }
-    });    
   },
 
   // how often to clean out expired cached views

js/views/pageNavVw.js

@@ -319,7 +319,6 @@ module.exports = baseVw.extend({
         self._lastSetAddressBarText = text;
         self.addressInput.val(text);
         self.closeStatusBar();
-        window.obEventBus.trigger('addressBarTextSet', text);
       });
       if (self.showDiscIntro){
         self.showDiscoverIntro();

js/views/pageVw.js

@@ -8,7 +8,7 @@ PageVw = BaseVw.extend({
 });
 
 // this must be a "static" method and overridden as such (if you
-// are overriding), since the router doesn't have an instance
+// are overriding) since the router doesn't have an instance
 // when it's deciding whether to create a new one or use a cached one.
 PageVw.getCacheIndex = function(fragment) {
   if (!fragment) {

js/views/userPageVw.js

@@ -1723,18 +1723,4 @@ UserPageVw = pageVw.extend({
 
 });
 
-UserPageVw.getCacheIndex = function(fragment) {
-  var splitFrag;
-
-  fragment = fragment || '';
-  splitFrag = fragment.split('/');
-
-  if (splitFrag.length > 1) {
-    return `userPage/${splitFrag[1]}`;
-  } else {
-    throw Error('The expectation is that the user page will be routed ' +
-      'with a minimum fragment of \'userPage\'/<guid>');
-  }
-};
-
 module.exports = UserPageVw;