Skip to content
This repository was archived by the owner on May 16, 2019. It is now read-only.

Commit 1c7a0e0

Browse files
committed
implemented code review comments
1 parent e277e5f commit 1c7a0e0

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed

css/obBase.css

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -207,21 +207,25 @@ form {
207207
width: 100%;
208208
z-index: 14;
209209
background-color: #327EB8;
210-
padding: 10px 8px;
210+
padding: 7px 8px 6px;
211211
box-sizing: border-box;
212212
-webkit-app-region: drag;
213213
}
214214

215215
#appBar .windowControls {
216216
position: absolute;
217217
left: 8px;
218-
top: 8px;
218+
top: 6px;
219219
}
220220

221221
html:not(.platform-mac) #appBar .windowControls {
222222
left: auto;
223223
right: 8px;
224-
top: 8px;
224+
top: 5px;
225+
}
226+
227+
#appBar .btn {
228+
-webkit-app-region: no-drag;
225229
}
226230

227231
#appBar .title {
@@ -233,7 +237,7 @@ html:not(.platform-mac) #appBar .windowControls {
233237

234238
#pageNav {
235239
position: fixed;
236-
top: 35px;
240+
top: 28px;
237241
-webkit-app-region: no-drag;
238242
z-index: 13;
239243
}
@@ -248,7 +252,7 @@ html:not(.platform-mac) #appBar .windowControls {
248252
}
249253

250254
#pageNav .navBar.bar {
251-
padding: 10px 8px;
255+
padding: 0 8px 10px;
252256
}
253257

254258
#pageNav .modal-about .navBar.bar {
@@ -268,7 +272,7 @@ html:not(.platform-mac) #appBar .windowControls {
268272
#sideBar {
269273
position: fixed;
270274
right: -183px;
271-
top: 85px;
275+
top: 68px;
272276
width:230px;
273277
background-color: #252525;
274278
border-left: 0;
@@ -1065,7 +1069,7 @@ label.fieldItem {
10651069
display: block;
10661070
width: 100%;
10671071
height: 100%;
1068-
top: 35px;
1072+
top: 28px;
10691073
left: 0;
10701074
transition: opacity .05s cubic-bezier(0, 0, 0.2, 1),
10711075
width 0.5s ease;
@@ -1082,7 +1086,7 @@ label.fieldItem {
10821086
}
10831087

10841088
.modal.modal-navOffset {
1085-
top: 85px;
1089+
top: 68px;
10861090
}
10871091

10881092
.modalHolder {
@@ -1483,17 +1487,17 @@ h5 {
14831487
.modal-opaque {
14841488
background-color: rgba(6, 55, 83, 0.80);
14851489
box-shadow: inset 0px -70px 112px -62px rgba(37,37,37,.9);
1486-
top: 85px;;
1490+
top: 68px;;
14871491
}
14881492
14891493
.modal-opaqueDark {
14901494
background-color: rgba(25,25,25,0.9);
14911495
box-shadow: inset 0px -70px 112px -62px rgba(37,37,37,.9);
1492-
top: 85px;
1496+
top: 68px;
14931497
}
14941498
14951499
.modal-opaque.modal-navBlock {
1496-
background: linear-gradient(to bottom, rgba(0,0,0,0.2), rgba(0,0,0,0.2) 85px, rgba(7,65,97,1) 86px);
1500+
background: linear-gradient(to bottom, rgba(0,0,0,0.2), rgba(0,0,0,0.2) 68px, rgba(7,65,97,1) 69px);
14971501
top: 0;
14981502
padding-top: 100px;
14991503
}
@@ -1503,7 +1507,7 @@ h5 {
15031507
which should never be covered.
15041508
*/
15051509
.modal-fullscreen {
1506-
top: 35px;
1510+
top: 28px;
15071511
}
15081512
15091513
.modal-childMain {
@@ -4640,7 +4644,7 @@ input[type="checkbox"].fieldItem:checked + label .togLabelOff {
46404644
padding-top: 20px;
46414645
-webkit-app-region: no-drag;
46424646
position: relative;
4643-
top: 85px;
4647+
top: 68px;
46444648
box-sizing: border-box;
46454649
}
46464650

js/views/buyWizardVw.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ module.exports = baseVw.extend({
391391
}
392392

393393
addressString = encodeURIComponent(addressString);
394-
$iFrame = $('<iframe class="js-iframe-pending positionTop" width="525" height="350" frameborder="0" style="border:0; margin-top: 0; height: 262px" />');
394+
$iFrame = $('<iframe class="js-iframe-pending positionTop" width="525" height="250" frameborder="0" style="border:0; margin-top: 0; height: 250px; clip: rect(0,0,0,0)" />');
395395

396396
if ($currentIframe.length) {
397397
this.$buyWizardMap.find('.js-mapSpinner').removeClass('hide');

0 commit comments

Comments
 (0)