Skip to content
This repository was archived by the owner on May 16, 2019. It is now read-only.

Commit 2350d96

Browse files
committed
Fixed missing data in chat notifications.
1 parent d0ecb7d commit 2350d96

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

js/templates/notification.html

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@
3737
<div class="textSize11px floatLeft txt-fade"><%= ob.moment(new Date(ob.timestamp*1000)).format('MMM D, h:mm A') %></div>
3838
<% } else if(ob.type == "ORDER") { %>
3939
<div class="textSize12px row5">
40-
<% if(ob.handle) { %>
41-
<%= polyglot.t('NotificationNewTransactionMessage',{name:ob.handle}) %>
40+
<% if(ob.username) { %>
41+
<%= polyglot.t('NotificationNewTransactionMessage',{name:ob.username}) %>
4242
<% }else{ %>
4343
<span class="inlineBlock top3">
44-
<%= polyglot.t('NotificationNewTransactionMessage',{name:ob.guid}) %>
44+
<%= polyglot.t('NotificationNewTransactionMessage',{name:ob.sender}) %>
4545
</span>
4646
<% } %>
4747
</div>
@@ -106,8 +106,12 @@
106106
<strong><%= polyglot.t('NotificationTitle',{title: ob.title}) %></strong>
107107
</span>
108108
<div class="textSize11px txt-fade textWeightNormal">
109-
<% if(ob.handle){ %>
109+
<% if(ob.username){ %>
110+
<%= polyglot.t('NotificationFrom',{name: ob.handle}) %>
111+
<% } else if(ob.handle){ %>
110112
<%= polyglot.t('NotificationFrom',{name: ob.handle}) %>
113+
<% } else if(ob.sender){ %>
114+
<%= polyglot.t('NotificationFrom',{name: ob.handle}) %>
111115
<% }else{ %>
112116
<%= polyglot.t('NotificationFrom',{name: ob.guid}) %>
113117
<% } %>

js/views/pageNavVw.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,17 @@ module.exports = baseVw.extend({
163163
avatarHash + '&guid=' + notif.guid : 'imgs/defaultUser.png';
164164
notif.type = notif.type || notif.message_type;
165165
notifStamp = Date.now();
166+
notif.guid = notif.guid || notif.sender;
166167

167168
this.unreadNotifsViaSocket++;
168169

169170
this.notificationsCl.add(
170-
__.extend({}, notif, { read: false })
171+
__.extend({}, notif, {
172+
read: false,
173+
username: username,
174+
image_hash: avatarHash,
175+
notifStamp: notifStamp,
176+
})
171177
);
172178

173179
//prevent message spamming from one user

js/views/userPageVw.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -909,8 +909,10 @@ module.exports = baseVw.extend({
909909

910910
this.listenTo(this.followerList, 'usersAdded', ()=>{
911911
var searchTerms = this.$('#inputFollowing').val();
912-
this.followingSearch.reIndex();
913-
searchTerms && this.followingSearch.search(searchTerms);
912+
if(this.followingSearch){
913+
this.followingSearch.reIndex();
914+
searchTerms && this.followingSearch.search(searchTerms);
915+
}
914916
});
915917
},
916918

@@ -1716,7 +1718,7 @@ module.exports = baseVw.extend({
17161718
baseVw.prototype.remove.apply(this, arguments);
17171719

17181720
// close colorbox to make sure the overlay doesnt remain open when going to a different page
1719-
$.colorbox.close();
1721+
//$.colorbox.close();
17201722
messageModal.$el.off('click', this.modalCloseHandler);
17211723
}
17221724

0 commit comments

Comments
 (0)