lint fixes

rmisio · rmisio · commit 4a60c5faf420 · 2016-06-16T10:53:55.000-07:00
diff --git a/js/views/aboutModal.js b/js/views/aboutModal.js
@@ -1,6 +1,7 @@
 'use strict';
 
-var loadTemplate = require('../utils/loadTemplate'),
+var __ = require('underscore'),
+    loadTemplate = require('../utils/loadTemplate'),
     baseModal = require('./baseModal');
 
 module.exports = baseModal.extend({
diff --git a/js/views/buyAddressesVw.js b/js/views/buyAddressesVw.js
@@ -1,7 +1,6 @@
 'use strict';
 
 var __ = require('underscore'),
-    Backbone = require('backbone'),
     $ = require('jquery'),
     loadTemplate = require('../utils/loadTemplate'),
     baseVw = require('./baseVw'),    
diff --git a/js/views/buyWizardVw.js b/js/views/buyWizardVw.js
@@ -1,7 +1,6 @@
 'use strict';
 
 var __ = require('underscore'),
-    Backbone = require('backbone'),
     $ = require('jquery'),
     loadTemplate = require('../utils/loadTemplate'),
     countriesModel = require('../models/countriesMd'),
@@ -549,7 +548,7 @@ module.exports = baseModal.extend({
             title: window.polyglot.t('errorMessages.contractError'),
             message: window.polyglot.t('errorMessages.sellerError') + ' ' +
               window.polyglot.t('errorMessages.checkPurchaseData') + '\n\n Reason: ' + data.reason
-          })
+          });
 
           self.$('.js-buyWizardSpinner').addClass('hide');
           //re-enable form so they can try again
diff --git a/js/views/dialog.js b/js/views/dialog.js
@@ -1,6 +1,7 @@
 'use strict';
 
-var loadTemplate = require('../utils/loadTemplate'),
+var __ = require('underscore'),
+    loadTemplate = require('../utils/loadTemplate'),
     baseModal = require('./baseModal'),
     Dialog;
 
diff --git a/js/views/hiddenWarningModal.js b/js/views/hiddenWarningModal.js
@@ -1,6 +1,7 @@
 'use strict';
 
-var loadTemplate = require('../utils/loadTemplate'),
+var __ = require('underscore'),
+    loadTemplate = require('../utils/loadTemplate'),
     baseModal = require('./baseModal');
 
 module.exports = baseModal.extend({
diff --git a/js/views/homeVw.js b/js/views/homeVw.js
@@ -562,7 +562,7 @@ module.exports = pageVw.extend({
           .replace('%{tag}', `<span class="btn-pill color-secondary">${hashedItem}</span>`)
       );
       this.$el.find('.js-homeSearchItemsClear').removeClass('hide');
-      this.$el.find('.js-homeSearchItems').val("#" + searchItemsText)
+      this.$el.find('.js-homeSearchItems').val("#" + searchItemsText);
       this.setState('products', searchItemsText);
     } else {
       this.searchItemsClear();
diff --git a/js/views/itemEditVw.js b/js/views/itemEditVw.js
@@ -645,7 +645,7 @@ module.exports = baseVw.extend({
       inputName = (($label = self.$("label[for='"+$(this).attr('id')+"']")).length && $label.text()) ||
         $(this).attr('data-label') || $(this).attr('id');
 
-      invalidInputList.push(inputName.trim())
+      invalidInputList.push(inputName.trim());
     });
 
     invalidInputList = __.uniq(invalidInputList);
diff --git a/js/views/itemShortVw.js b/js/views/itemShortVw.js
@@ -95,12 +95,10 @@ module.exports = baseVw.extend({
   },
 
   deleteItemClick: function(e){
-    console.log("1")
     this.$(e.target).closest('.gridItemControls').find(".js-deleteOverlay").addClass("fadeIn");
   },
 
   cancelConfirmDelete: function(e){
-    console.log("2")
     e.stopPropagation();
     this.$(e.target).closest('.gridItemControls').find(".js-deleteOverlay").removeClass("fadeIn");
   },
diff --git a/js/views/loadingModal.js b/js/views/loadingModal.js
@@ -1,6 +1,7 @@
 'use strict';
 
-var loadTemplate = require('../utils/loadTemplate'),
+var __ = require('underscore'),
+    loadTemplate = require('../utils/loadTemplate'),
     baseModal = require('./baseModal');
 
 module.exports = baseModal.extend({
diff --git a/js/views/moderatorSettingsModal.js b/js/views/moderatorSettingsModal.js
@@ -1,7 +1,6 @@
 'use strict';
 
-var Backbone = require('backbone'),
-    $ = require('jquery'),
+var $ = require('jquery'),
     loadTemplate = require('../utils/loadTemplate'),
     app = require('../App').getApp(),
     saveToAPI = require('../utils/saveToAPI'),
@@ -20,7 +19,7 @@ module.exports = baseModal.extend({
     'blur input': 'validateInput'
   },
 
-  initialize: function(options){
+  initialize: function(){
     this.moderatorStatus = true;
     this.oldFeeValue = 0;
   },
@@ -113,7 +112,7 @@ module.exports = baseModal.extend({
     $(e.target).closest('.flexRow').addClass('formChecked');
   },
 
-  onCloseClick: function(e) {
+  onCloseClick: function() {
     this.close();
   }
 });
diff --git a/js/views/onboardingModal.js b/js/views/onboardingModal.js
@@ -277,7 +277,7 @@ module.exports = baseModal.extend({
 
     if (this.$('#storeNameInput').val() != ""){
       self.model.set('name', this.$('#storeNameInput').val());
-    } else if (self.model.get('name') == undefined){
+    } else if (typeof self.model.get('name') === 'undefined'){
         //otherwise error since the profile api needs the name parameter and as of now it is not set in the userMd.js
       self.model.set('name', "ob" + Math.random().toString(36).slice(2));
     }
diff --git a/js/views/serverConfigsVw.js b/js/views/serverConfigsVw.js
@@ -21,7 +21,7 @@ module.exports = BaseVw.extend({
 
     this.connectionState = {};
     this.collection.forEach((md) => {
-      this.connectionState[md.id] = { status: 'not-connected' }
+      this.connectionState[md.id] = { status: 'not-connected' };
     });
 
     this.listenTo(this.collection, 'update', this.render);
diff --git a/js/views/settingsVw.js b/js/views/settingsVw.js
@@ -14,7 +14,6 @@ var __ = require('underscore'),
     userShortView = require('./userShortVw'),
     userShortModel = require('../models/userShortMd'),
     countriesModel = require('../models/countriesMd'),
-    app = require('../App').getApp(),
     cropit = require('../utils/jquery.cropit'),
     chosen = require('../utils/chosen.jquery.min.js'),
     setTheme = require('../utils/setTheme.js'),
@@ -1031,12 +1030,11 @@ module.exports = pageVw.extend({
       
       window.obEventBus.trigger("updateProfile");
       self.refreshView();
-      }, function(){
-        self.scrollToFirstError(self.$('#moderatorForm'));
-      }, moderatorData).always(function(){
-        $saveBtn.removeClass('loading');
-      }
-    );
+    }, function(){
+      self.scrollToFirstError(self.$('#moderatorForm'));
+    }, moderatorData).always(function(){
+      $saveBtn.removeClass('loading');
+    });
 
     $.ajax({
       type: "POST",
diff --git a/js/views/simpleMessageModal.js b/js/views/simpleMessageModal.js
@@ -1,6 +1,7 @@
 'use strict';
 
-var loadTemplate = require('../utils/loadTemplate'),
+var __ = require('underscore'),
+    loadTemplate = require('../utils/loadTemplate'),
     baseModal = require('./baseModal');
 
 /*
@@ -17,8 +18,6 @@ module.exports = baseModal.extend({
   },
 
   constructor: function(options) {
-    var events = {};
-
     options = __.extend({
       innerWrapperClass: 'modal-child modal-childMain color-primary custCol-primary padding20'
     }, options || {});
diff --git a/js/views/socketVw.js b/js/views/socketVw.js
@@ -1,7 +1,6 @@
 'use strict';
 
 var Backbone = require('backbone'),
-    $ = require('jquery'),
     app = require('../App.js').getApp();
 
 module.exports = Backbone.View.extend({
diff --git a/js/views/storeWizardVw.js b/js/views/storeWizardVw.js
@@ -1,7 +1,6 @@
 'use strict';
 
-var Backbone = require('backbone'),
-    $ = require('jquery'),
+var $ = require('jquery'),
     loadTemplate = require('../utils/loadTemplate'),
     saveToAPI = require('../utils/saveToAPI'),
     MediumEditor = require('medium-editor'),
diff --git a/js/views/transactionsVw.js b/js/views/transactionsVw.js
@@ -114,12 +114,10 @@ module.exports = pageVw.extend({
                 self.renderTab("cases");
               },
               error: function(jqXHR, status, errorThrown){
-                self.registerChild(
-                  new Dialog({
-                    title: window.polyglot.t('errorMessages.getError'),
-                    message: '<i>' + errorThrown + '</i>'
-                  })
-                );
+                app.simpleMessageModal.open({
+                  title: window.polyglot.t('errorMessages.getError'),
+                  message: '<i>' + errorThrown + '</i>'
+                });
 
                 console.log(jqXHR);
                 console.log(status);
@@ -158,12 +156,10 @@ module.exports = pageVw.extend({
             });
           },
           error: function(jqXHR, status, errorThrown){
-            self.registerChild(
-              new Dialog({
-                title: window.polyglot.t('errorMessages.getError'),
-                message: '<i>' + errorThrown + '</i>'
-              })
-            );
+            app.simpleMessageModal.open({
+              title: window.polyglot.t('errorMessages.getError'),
+              message: '<i>' + errorThrown + '</i>'
+            });
 
             console.log(jqXHR);
             console.log(status);
@@ -172,12 +168,10 @@ module.exports = pageVw.extend({
         });
       },
       error: function(jqXHR, status, errorThrown){
-        self.registerChild(
-          new Dialog({
-            title: window.polyglot.t('errorMessages.getError'),
-            message: '<i>' + errorThrown + '</i>'
-          })
-        );
+        app.simpleMessageModal.open({
+          title: window.polyglot.t('errorMessages.getError'),
+          message: '<i>' + errorThrown + '</i>'
+        });
 
         console.log(jqXHR);
         console.log(status);
@@ -420,11 +414,9 @@ module.exports = pageVw.extend({
           if (calls.length > 0){
             exportData(this.currentExportData);
           } else {
-            self.registerChild(
-              new Dialog({
-                title: window.polyglot.t('errorMessages.noData')
-              })
-            );            
+            app.simpleMessageModal.open({
+              title: window.polyglot.t('errorMessages.noData')
+            });           
           }
         });
   },
diff --git a/js/views/userPageVw.js b/js/views/userPageVw.js
