Skip to content
This repository was archived by the owner on May 16, 2019. It is now read-only.

Commit 6653218

Browse files
authored
Merge pull request #1831 from OpenBazaar/cleanUpAboutVsDescription
Clean Up About/Description labels
2 parents b14abc2 + 1bf30de commit 6653218

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

js/languages/en-US.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,7 @@
221221
"ExpirationDate": "Expires On",
222222
"UploadCoverPhoto": "Upload a cover photo",
223223
"ShortDescription": "Short Description",
224+
"ShortDescriptionPlaceholder": "Say something interesting... (160 char max)",
224225
"PrimaryColor": "Primary Color",
225226
"SecondaryColor": "Secondary Color",
226227
"TextColor": "Text Color",
@@ -620,7 +621,6 @@
620621
"CountryPlaceholder": "Search for country",
621622
"CurrencyPlaceholder": "Search for currency",
622623
"TimezonePlaceholder": "Search for time Zone",
623-
"ShortDescriptionPlaceholder": "Say something interesting... (160 char max)",
624624
"timeZone": "Select Your Time Zone",
625625
"yourDetails": "Set Your Information",
626626
"yourDescription": "Description",

js/templates/onboardingModal.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,15 +128,16 @@
128128
<div class="flexRow borderBottom custCol-border">
129129
<div class="flexCol-3 borderRight custCol-border">
130130
<label class="fieldItem" for="aboutInput">
131-
<%= polyglot.t('Description') %>
131+
<%= polyglot.t('ShortDescription') %>
132132
</label>
133133
</div>
134134
<div class="flexCol-9">
135-
<textarea name="about"
136-
rows="5"
135+
<textarea name="short_description"
136+
rows="3"
137+
maxlength="160"
137138
id="aboutInput"
138139
class="fieldItem-textarea custCol-text customThemeScrollbar"
139-
placeholder="<%= polyglot.t('onboarding.ShortDescriptionPlaceholder') %>"></textarea>
140+
placeholder="<%= polyglot.t('ShortDescriptionPlaceholder') %>"></textarea>
140141
</div>
141142
</div>
142143
<div class="flexRow borderBottom custCol-border">

js/templates/settings.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ <h3 class="padding15 margin0 fontWeight500"><%= polyglot.t('Basic') %></h3>
255255
rows="2"
256256
class="fieldItem-textarea"
257257
maxlength="160"
258-
placeholder="<%= polyglot.t('onboarding.ShortDescriptionPlaceholder') %>"><%= ob.page.profile.short_description %></textarea>
258+
placeholder="<%= polyglot.t('ShortDescriptionPlaceholder') %>"><%= ob.page.profile.short_description %></textarea>
259259
</div>
260260
</div>
261261

js/templates/storeWizard.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
<div class="flexRow custCol-border">
3131
<div class="flexCol-4 borderRight custCol-border">
3232
<label class="fieldItem" for="aboutInput">
33-
<%= polyglot.t('Description') %>
33+
<%= polyglot.t('About') %>
3434
<div class="note rowTop5">
3535
<%= polyglot.t('HighlightToStyle') %>
3636
</div>

0 commit comments

Comments
 (0)