Skip to content
This repository was archived by the owner on May 16, 2019. It is now read-only.

Commit 8a19a9b

Browse files
authored
Merge pull request #1800 from OpenBazaar/enableAvatarRotateOnLoad
Disable rotate and zoom on avatar until the image is loaded.
2 parents ed21653 + cee1ad3 commit 8a19a9b

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

js/templates/settings.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -266,14 +266,14 @@ <h3 class="padding15 margin0 fontWeight500"><%= polyglot.t('Basic') %></h3>
266266
<div class="statusBar navBar fadeOut positionAbsolute js-avatarLoading">
267267
<div class="pad20 rowTop20 width100"><h4 class="txt-center"><%= polyglot.t('LoadingImage') %></h4></div>
268268
</div>
269-
<div class="cropit-image-preview cropit-avatar js-settingsAvatarPreview rowTop20 thumbnail thumbnail-huge box-border pull-left row20 marginLeft12"></div>
270-
<div class="pull-left marginLeft12 flexCol-3">
271-
<div>
272-
<input type="range" class="cropit-image-zoom-input rowTop20 row20 hide" />
269+
<div class="cropit-image-preview cropit-avatar js-settingsAvatarPreview rowTop20 thumbnail thumbnail-huge box-border row20 marginLeft12"></div>
270+
<div class="rowTop20 marginLeft12 flexCol-3">
271+
<div class="flexRow row20">
272+
<a class="btn flexExpand marginRight5 color-secondary custCol-secondary ion-reply disabled js-avatarRotateLeft"></a>
273+
<a class="btn flexExpand marginLeft5 color-secondary custCol-secondary ion-forward disabled js-avatarRotateRight"></a>
273274
</div>
274-
<div class="flexRow">
275-
<a class="btn flexExpand marginRight5 color-secondary custCol-secondary ion-reply js-avatarRotateLeft"></a>
276-
<a class="btn flexExpand marginLeft5 color-secondary custCol-secondary ion-forward js-avatarRotateRight"></a>
275+
<div>
276+
<input type="range" class="cropit-image-zoom-input row20 disabled js-avatarZoom" />
277277
</div>
278278
<div>
279279
<input type="file" id="settingsAvatarInput" class="cropit-image-input hide" />

js/views/settingsVw.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,11 +247,11 @@ module.exports = pageVw.extend({
247247
console.log(data);
248248
},
249249
onImageLoading: function(){
250-
self.$('.cropit-image-zoom-input').removeClass('hide');
251250
self.newAvatar = true;
252251
self.$('.js-avatarLoading').removeClass('fadeOut');
253252
},
254253
onImageLoaded: function(){
254+
self.$('.js-avatarZoom, .js-avatarRotateLeft, .js-avatarRotateRight').removeClass('disabled');
255255
self.$('.js-avatarLoading').addClass('fadeOut');
256256
},
257257
onImageError: function(errorObject, errorCode, errorMessage){

0 commit comments

Comments
 (0)