fixing eslint issues

Author: jjeffryes

.eslintrc

@@ -50,7 +50,6 @@
     "no-extend-native": 2,
     "no-extra-bind": 2,
     "no-extra-boolean-cast": 2,
-    "no-extra-parens": [2, "all", {"nestedBinaryExpressions": false}],
     "no-extra-semi": 2,
     "no-fallthrough": 2,
     "no-floating-decimal": 2,

js/start.js

@@ -460,7 +460,7 @@ var loadProfile = function(landingRoute, onboarded) {
               };
 
               // any lang changes after our app has loaded will need an app re-start to fully take effect
-              user.on('change:language', function(md, lang) {
+              user.on('change:language', function() {
                 var restartWarning;
 
                 restartWarning = new Dialog({

js/views/baseModal.js

@@ -53,8 +53,7 @@ baseModal = baseVw.extend({
   },
 
   __onDocKeypress: function(e) {
-    var openModals = baseModal.__openModals,
-        topModal = this.__getTopModal();
+    var topModal = this.__getTopModal();
 
     if (this.__options.dismissOnEscPress && e.keyCode === 27 &&
       topModal && topModal === this) {
@@ -83,11 +82,10 @@ baseModal = baseVw.extend({
       var aZindex = parseInt(window.getComputedStyle(a.modal.el).zIndex) || 0,
           bZindex = parseInt(window.getComputedStyle(b.modal.el).zIndex) || 0;
 
-      if (aZindex ===  bZindex) {
+      if (aZindex === bZindex) {
         return (a.index < b.index) ? -1 : (a.index > b.index) ? 1 : 0;
-      } else {
-        return (aZindex < bZindex) ? -1 : (aZindex > bZindex) ? 1 : 0;
-      }      
+      }
+      return (aZindex < bZindex) ? -1 : (aZindex > bZindex) ? 1 : 0;
     });
 
     return openModals[openModals.length - 1] && openModals[openModals.length - 1].modal;

js/views/transactionsVw.js

@@ -367,8 +367,7 @@ module.exports = pageVw.extend({
           tempAnchor.href = window.URL.createObjectURL(dataBlob);
           tempAnchor.download = ('export_'+saveDate.toLocaleString(window.lang)+'.csv').replace(/,/g, '_');
           tempAnchor.click();
-        },
-        self = this;
+        };
 
     //clear existing data
     this.currentExportData = [];
@@ -399,12 +398,10 @@ module.exports = pageVw.extend({
 
     return $.when.apply(null, calls)
         .fail(function(){
-          self.registerChild(
-            new Dialog({
-              title: window.polyglot.t('errorMessages.getError'),
-              message: window.polyglot.t('errorMessages.serverError')
-            })
-          );
+          app.simpleMessageModal.open({
+            title: window.polyglot.t('errorMessages.getError'),
+            message: window.polyglot.t('errorMessages.serverError')
+          });
 
           calls.forEach(call => {
             call.abort();