Updated moderator list is correctly fetched after adding or removing a moderator via the add/remove moderator button. The GetIsModerator function has been shortened, and some logic was moved to the template.

Based on a bunch of advice from jjeffryes. Thanks!

Author: Dekker3D

js/templates/userPage.html

@@ -137,26 +137,28 @@ <h1 class="page-userNameLarge floatLeft fancy-heading fontSize20 colorWhiteForce
                     </span>
                   </a>
                 </div>
-			          <div class="ctrlGroup hide js-notOwnPageButtons js-userPageControls">
-                <a class="btn btn-txt custCol-primary hide js-addmoderator">
-                  <span class="ion-person-add fontSize11 marginRight2 textOpacity1"></span>
-                  <%= polyglot.t('AddModerator') %>
-                </a>
-                <a class="btn btn-txt custCol-primary hide confirmable js-removemoderator">
-                  <span class="preSpacer">
-                    <span class="ion-eye-disabled fontSize11 marginRight2 textOpacity1"></span>
-                    <%= polyglot.t('RemoveModerator') %>
-                  </span>
-                  <span class="preConfirm">
-                    <span class="ion-trash-b fontSize11 marginRight2 textOpacity1"></span>
-                    <%= polyglot.t('RemoveModerator') %>
-                  </span>
-                  <span class="postConfirm">
-                    <span class="ion-trash-b fontSize11 marginRight2 textOpacity1"></span>
-                    <%= polyglot.t('ConfirmRemoveModerator') %>
-                  </span>
-                </a>
-              </div>
+                <% if(ob.page.profile.moderator) { %>
+  			          <div class="ctrlGroup hide js-notOwnPageButtons js-userPageControls">
+                  <a class="btn btn-txt custCol-primary hide js-addmoderator">
+                    <span class="ion-person-add fontSize11 marginRight2 textOpacity1"></span>
+                    <%= polyglot.t('AddModerator') %>
+                  </a>
+                  <a class="btn btn-txt custCol-primary hide confirmable js-removemoderator">
+                    <span class="preSpacer">
+                      <span class="ion-eye-disabled fontSize11 marginRight2 textOpacity1"></span>
+                      <%= polyglot.t('RemoveModerator') %>
+                    </span>
+                    <span class="preConfirm">
+                      <span class="ion-trash-b fontSize11 marginRight2 textOpacity1"></span>
+                      <%= polyglot.t('RemoveModerator') %>
+                    </span>
+                    <span class="postConfirm">
+                      <span class="ion-trash-b fontSize11 marginRight2 textOpacity1"></span>
+                      <%= polyglot.t('ConfirmRemoveModerator') %>
+                    </span>
+                  </a>
+                </div>
+              <% } %>
                 <div class="ctrlGroup hide js-notOwnPageButtons js-userPageControls">
                   <a class="btn btn-txt custCol-primary js-message">
                     <span class="ion-email fontSize11 marginRight2 textOpacity1"></span>

js/views/userPageVw.js

@@ -708,20 +708,8 @@ module.exports = baseVw.extend({
   },
 
   getIsModerator: function () {
-  	if(this.userProfile.get('profile').moderator == true && this.options.ownPage == false && this.model.get('user').vendor) {
-  	  var pageGuid = this.userProfile.get('profile').guid;
-  	  var mods = this.model.get('user').moderators;
-  	  var found = false;
-      var self = this;
-  	  this.toggleModeratorButtons(false);
-      __.each(mods, function(mod) {
-    		if(mod.guid == pageGuid || mod == pageGuid) {
-    		  found = true;
-    		}
-      });
-      if(found == true) {
-        this.toggleModeratorButtons(true);
-      }
+  	if(this.options.ownPage == false && this.model.get('user').vendor) {
+      this.toggleModeratorButtons(Boolean(__.findWhere(this.model.get('user').moderators, {guid: this.pageID})));
     }
   },
 
@@ -1465,19 +1453,27 @@ module.exports = baseVw.extend({
     user.moderators = modList.moderators;
 
     saveToAPI('', user, user.serverUrl + "settings",
-        function(){
-          // confirmed
-          $targ.removeClass('loading');
-        },
-        function(){
-          // failed
-        }, modList,'',
-        function(){
-          // invalid
-        }).always(function(){
-          $targ.removeClass('loading');
-          self.getIsModerator();
+      function(){
+        // confirmed
+        $targ.removeClass('loading');
+      },
+      function(){
+        // failed
+      }, modList,'',
+      function(){
+        // invalid
+      }).always(function(){
+        $targ.removeClass('loading');
+        self.options.userModel.fetch({
+          success: function(model, response) {
+            if (self.isRemoved()) return;
+            var user = self.model.get('user');
+            user.moderators = model.get('moderators');
+            user.moderator_guids = model.get('moderator_guids');
+            self.getIsModerator();
+          }
         });
+      });
   },
 
   removeModeratorClick: function(e){
@@ -1513,7 +1509,15 @@ module.exports = baseVw.extend({
             // invalid
           }).always(function(){
             $targ.removeClass('loading');
-            self.getIsModerator();
+            self.options.userModel.fetch({
+              success: function(model, response) {
+                if (self.isRemoved()) return;
+                var user = self.model.get('user');
+                user.moderators = model.get('moderators');
+                user.moderator_guids = model.get('moderator_guids');
+                self.getIsModerator();
+              }
+            });
           });
     } else {
       $targ.addClass('confirm');