Improve history tracking

- makes sure home and settings state changes aren't added to history
- fixes history ends on Discover bug
- doesn't increment history on idex, or if same page is navigated to
twice
- makes disabled states visible when advanced graphics are turned off

Author: jjeffryes

css/obBase.css

@@ -5867,7 +5867,31 @@ input[type="checkbox"].fieldItem:checked + label .togLabelOff {
 
 #ov1.notFancy .notFancyDarkBackground,
 #ov1.notFancy #obContainer .notFancyDarkBackground {
-  background: #262626;
+  background: #262626 !important;
+}
+
+#ov1.notFancy .disabled,
+#ov1.notFancy #userPage .disabled,
+#ov1.notFancy #obContainer .disabled,
+#ov1.notFancy #overlay .disabled,
+#ov1.notFancy #sideBar .disabled,
+#ov1.notFancy #pageNav .disabled,
+#ov1.notFancy #modalHolder .disabled,
+#ov1.notFancy #messageModal .disabled,
+#ov1.notFancy #statusBar .disabled {
+  opacity: 0.2 !important;
+}
+
+#ov1.notFancy .disabled2,
+#ov1.notFancy #userPage .disabled2,
+#ov1.notFancy #obContainer .disabled2,
+#ov1.notFancy #overlay .disabled2,
+#ov1.notFancy #sideBar .disabled2,
+#ov1.notFancy #pageNav .disabled2,
+#ov1.notFancy #modalHolder .disabled2,
+#ov1.notFancy #messageModal .disabled2,
+#ov1.notFancy #statusBar .disabled2 {
+  opacity: 0.7 !important;
 }
 
 /* add a shadow and a glow, so modal close buttons are still barely visible if the user picks a bad color */

js/router.js

@@ -48,7 +48,6 @@ module.exports = Backbone.Router.extend({
         this.navigate(translatedRoute, { trigger: true });
       });
     });
-    
     history.size = -1;
     history.position = -1;
     history.action = 'default';
@@ -108,17 +107,19 @@ module.exports = Backbone.Router.extend({
     return deferred.promise();
   },
 
-  execute: function(callback, args) {
+  execute: function(callback, args, name) {
     if (history.action == 'default') {
-        history.position += 1;
-        history.size = history.position;
+      history.position += 1;
+      history.size = history.position;
     } else if (history.action == 'back') {
-        history.position -= 1;
-    } else if (history.action == 'forward') {
+      history.position -= 1;
+    } else if(history.action == 'forward' && this.previousName != name && name != "index") {
+      //don't increment if the same state is navigated to twice
+      //don't increment on index since that isn't a real state
         history.position += 1;
     }
     history.action = 'default';
-    
+
     if (history.position == history.size)
         $('.js-navFwd').addClass('disabled');
     else

js/views/homeVw.js

@@ -290,10 +290,10 @@ module.exports = baseVw.extend({
       this.searchItemsText = searchItemsText;
 
       //add action to history
-      Backbone.history.navigate("#home/" + state + "/" + searchItemsText.replace(/ /g, ""));
+      Backbone.history.navigate("#home/" + state + "/" + searchItemsText.replace(/ /g, ""), { replace: true });
     } else {
       //add action to history
-      Backbone.history.navigate("#home/" + state);
+      Backbone.history.navigate("#home/" + state, { replace: true });
     }
 
     this.state = state;

js/views/settingsVw.js

@@ -528,7 +528,7 @@ module.exports = Backbone.View.extend({
 
   addTabToHistory: function(state){
     //add action to history
-    Backbone.history.navigate("#settings/" + state);
+    Backbone.history.navigate("#settings/" + state, { replace: true });
     this.options.state = state;
   },