Skip to content
This repository was archived by the owner on May 16, 2019. It is now read-only.

Commit abcfc15

Browse files
committed
Fix old out of date inline height, fix duplicate height in attribute and style of iframe, remove check in address to match only name and country being required in an address.
1 parent c55a2ec commit abcfc15

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

js/templates/buyWizard.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<div class="modal-hero js-buyWizardHero custCol-text shadow-inner1-light"
22
style="background-image: url(<%= ob.serverUrl %>get_image?hash=<%= ob.vendor_offer.listing.item.image_hashes[0] %><%= ob.imageExtension %>), url(imgs/defaultBanner.png);">
3-
<div class="js-buyWizardMap buyWizardMap positionRelative hide" style="height: 262px">
3+
<div class="js-buyWizardMap buyWizardMap positionRelative hide" style="height: 250px">
44
<div class="js-mapSpinner txt-col1 ion-android-sync spinner spinner-slow icon-large icon-circle-background1 zIndex1 fullCentered" style="border: 1px solid #aaa;"></div>
55
<div class="flexContainer mapWrap"></div>
66
</div>

js/views/buyWizardVw.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -398,15 +398,16 @@ module.exports = baseModal.extend({
398398
$currentIframe = this.$buyWizardMap.find('iframe');
399399
$currentIframe.addClass('blurMore');
400400

401-
if (address && address.street && address.city && address.state && address.postal_code) {
402-
addressString = address.street + ", " + address.city + ", " + address.state + " " + address.postal_code + " " + address.displayCountry;
401+
if (address) {
402+
addressString = address.street + " " + address.city + " " + address.state + " " + address.postal_code + " " + address.displayCountry;
403+
addressString = addressString.trim();
403404
} else {
404405
// if address is invalid, we'll create a dummy address for which google maps will show a map of the world
405406
addressString = "123 Street, City, State 12345 Country";
406407
}
407408

408409
addressString = encodeURIComponent(addressString);
409-
var $iFrame = $('<iframe class="js-iframe-pending positionTop" width="525" height="250" frameborder="0" style="border:0; margin-top: 0; height: 250px;" />');
410+
var $iFrame = $('<iframe class="js-iframe-pending positionTop" width="525" height="250" frameborder="0" style="border:0; margin-top: 0;" />');
410411

411412
if ($currentIframe.length) {
412413
this.$buyWizardMap.find('.js-mapSpinner').removeClass('hide');

0 commit comments

Comments
 (0)