Better fix to icon issue in Settings.

jjeffryes · jjeffryes · commit b8a9d34c052f · 2016-10-05T13:19:41.000-04:00
diff --git a/css/obBase.css b/css/obBase.css
@@ -1931,7 +1931,6 @@ input[type="text"].txtField-bar {
   margin-right: 6px;
 }
 
-.btn *[class *= "ion-"],
 .btn *[class *= "ion-"]:before {
   pointer-events: none; /* don't fire clicks on icon */
 }
diff --git a/js/views/settingsVw.js b/js/views/settingsVw.js
@@ -675,7 +675,7 @@ module.exports = pageVw.extend({
   },
 
   tabClick: function(e){
-    var tab = $(e.target).data('tab');
+    var tab = $(e.target).closest('.btn-tab').data('tab');
     this.setState(tab);
     this.addTabToHistory(tab);
   },

Original file line number	Diff line number	Diff line change
`@@ -1931,7 +1931,6 @@ input[type="text"].txtField-bar {`
`1931`	`1931`	`margin-right: 6px;`
`1932`	`1932`	`}`
`1933`	`1933`
`1934`		`-.btn [class = "ion-"],`
`1935`	`1934`	`.btn [class = "ion-"]:before {`
`1936`	`1935`	`pointer-events: none; /* don't fire clicks on icon */`
`1937`	`1936`	`}`