more issues with re-implementing the state on cached userPage views

Author: rmisio

js/router.js

@@ -222,6 +222,7 @@ module.exports = Backbone.Router.extend({
     options.viewArgs = options.viewArgs.length ? options.viewArgs : [options.viewArgs];
 
     this.cleanup();
+    window.obEventBus.trigger('setAddressBar', options.addressBarText);
 
     $('body').attr('id', options.bodyID);
     $('body').attr('class', options.bodyClass);
@@ -267,22 +268,21 @@ module.exports = Backbone.Router.extend({
         this.$obContainer[0].scrollTop = this.view.__cachedScrollPos || 0;
       }
 
-      if (this.view.__cachedAddressBarText) {
-        // ensure our address bar text reflects the state of the cached view
-        window.obEventBus.trigger('setAddressBar', {'addressText': this.view.__cachedAddressBarText});
-      } else {
-        window.obEventBus.trigger('setAddressBar', options.addressBarText);
-      }
+      // if (this.view.__cachedAddressBarText) {
+      //   // ensure our address bar text reflects the state of the cached view
+      //   window.obEventBus.trigger('setAddressBar', {'addressText': this.view.__cachedAddressBarText});
+      // } else {
+      //   window.obEventBus.trigger('setAddressBar', options.addressBarText);
+      // }
 
       this.trigger('cache-reattach', {
         view: this.view,
-        requestedRoute: requestedRoute,
-        cachedRoute: Backbone.history.getFragment()
+        route: requestedRoute
       });
     } else {
       this.view = new (Function.prototype.bind.apply(View, [null].concat(options.viewArgs)));
-      // clear address bar. Must happen after we set out view above.
-      window.obEventBus.trigger('setAddressBar', options.addressBarText);
+      // // clear address bar. Must happen after we set out view above.
+      // window.obEventBus.trigger('setAddressBar', options.addressBarText);
       $('#content').html(this.view.$el);
       this.$obContainer[0].scrollTop = 0;
 

js/views/homeVw.js

@@ -76,7 +76,7 @@ module.exports = pageVw.extend({
   },
 
   onCacheReattach: function(e) {
-    var splitRoute = e.requestedRoute.split('/'),
+    var splitRoute = e.route.split('/'),
         searchText;
 
     if (e.view !== this) return;

js/views/itemListVw.js

@@ -2,13 +2,12 @@
 
 var __ = require('underscore'),
     Backbone = require('backbone'),
-    //$ = require('jquery'),
-    //loadTemplate = require('../utils/loadTemplate'),
+    baseVw = require('./baseVw'),
     itemsShortCollection = require('../collections/itemsShortCl'),
     itemShortView = require('./itemShortVw'),
     simpleMessageView = require('./simpleMessageVw');
 
-module.exports = Backbone.View.extend({
+module.exports = baseVw.extend({
 
   initialize: function(options){
     this.options = options || {};
@@ -18,8 +17,12 @@ module.exports = Backbone.View.extend({
     //this.listenTo(this.options.userModel, 'change', function(){
     //  self.render();
     //});
-    this.subViews = [];
-    this.render();
+    
+    // as of now, our base view doesn't support registerChild happening
+    // before the view is fully initialized, hence the timeout here:
+    setTimeout(() => {
+      this.render();
+    });
   },
 
   render: function(){
@@ -42,24 +45,12 @@ module.exports = Backbone.View.extend({
       model: item,
       parentEl: this.$el
     });
-    this.subViews.push(itemShort);
+    // this.$el.append(itemShort.render().$el);
+    this.registerChild(itemShort);
   },
 
   renderNoneFound: function(){
     var simpleMessage = new simpleMessageView({title: this.options.title, message: this.options.message, el: this.$el});
-    this.subViews.push(simpleMessage);
-  },
-
-  close: function(){
-    __.each(this.subViews, function(subView) {
-      if (subView.close){
-        subView.close();
-      } else {
-        subView.unbind();
-        subView.remove();
-      }
-    });
-    this.unbind();
-    this.remove();
+    this.registerChild(simpleMessage);
   }
 });

js/views/userPageVw.js

@@ -331,12 +331,20 @@ UserPageVw = pageVw.extend({
   },
 
   onCacheReattach: function(e) {
+    var splitRoute = e.route.split('/'),
+        state;
+
     if (e.view !== this) return;
 
     // todo: cache the million dom queries for #obContainer
     // use in this view
     $('#obContainer').on('scroll', this.onScroll);
     this.setCustomStyles();
+
+    if (splitRoute.length > 2 && splitRoute[2] !== this.state) {
+      this.setState(splitRoute[2], splitRoute[3], { replaceState: true });
+    }
+
   },
 
   onCacheDetach: function(e) {
@@ -474,6 +482,7 @@ UserPageVw = pageVw.extend({
     if (state === "listing"){
       //clear old templates
       this.$el.find('.js-list4').html("");
+      this.tabClick(this.$el.find('.js-storeTab'), this.$el.find('.js-item'));
       this.renderItem(hash);
       $('#obContainer').scrollTop(352);
     } else if (state === "listingOld") {
@@ -991,7 +1000,6 @@ UserPageVw = pageVw.extend({
     var self = this;
     this.setItem(hash, function(model, response) {
       if (response.vendor_offer){
-        self.tabClick(self.$el.find('.js-storeTab'), self.$el.find('.js-item'));
         self.loadingDeferred.resolve();
       } else {
         self.loadingDeferred.reject();