Merge pull request #1494 from OpenBazaar/fixLongFollowerLists

prevent too many calls to get_followers

Author: jjeffryes

js/views/userListVw.js

@@ -25,8 +25,7 @@ module.exports = Backbone.View.extend({
     this.usersShort = new usersShortCollection(this.model);
     this.options.reverse && this.usersShort.models.reverse();
     this.subViews = [];
-    this.showPerScroll = 10;
-    this.fetchMoreAfter = options.perFetch;
+    this.showPerScroll = 30;
     this.nextUserToShow = 0;
     this.fetchedUsers = this.usersShort.length;
     this.totalUsers = this.options.followerCount;
@@ -81,8 +80,7 @@ module.exports = Backbone.View.extend({
 
     this.nextUserToShow = this.nextUserToShow >= this.fetchedUsers ? this.nextUserToShow : this.nextUserToShow + this.showPerScroll;
 
-    if(this.fetchMoreAfter && end == this.fetchMoreAfter && this.fetchedUsers < this.totalUsers){
-      this.fetchMoreAfter = this.fetchMoreAfter + this.options.perFetch;
+    if(this.fetchedUsers < this.totalUsers && this.$el.is(':visible')){
       this.trigger('fetchMoreUsers');
     }
   },

js/views/userPageVw.js

@@ -700,6 +700,13 @@ module.exports = baseVw.extend({
       //don't fetch again if all of the followers have been fetched
       return;
     }
+    
+    if(this.fetchingFollowers){
+      //don't cue up multiple calls
+      return;
+    }
+
+    this.fetchingFollowers = true;
 
     if(this.options.ownPage){
       fetchFollowersParameters = $.param({'start': this.followerFetchStart});
@@ -727,6 +734,7 @@ module.exports = baseVw.extend({
         messageModal.show(window.polyglot.t('errorMessages.notFoundError'), window.polyglot.t('Followers'));
       },
       complete: function(xhr, textStatus) {
+        self.fetchingFollowers = false;
         if(textStatus == 'parsererror'){
           messageModal.show(window.polyglot.t('errorMessages.serverError'), window.polyglot.t('errorMessages.badJSON'));
           throw new Error("The followers data returned from the API has a parsing error.");