Skip to content
This repository was archived by the owner on May 16, 2019. It is now read-only.

Commit 2935ba4

Browse files
author
Tom Galloway
committed
Extra tests.
1 parent cf0c0c4 commit 2935ba4

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

market/listeners.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import json
55
import time
66
import random
7+
from log import Logger
78
from interfaces import MessageListener, BroadcastListener, NotificationListener
89
from zope.interface import implements
910
from protos.objects import PlaintextMessage, Following
@@ -19,6 +20,7 @@ class MessageListenerImpl(object):
1920
def __init__(self, web_socket_factory, database):
2021
self.ws = web_socket_factory
2122
self.db = database
23+
self.log = Logger(system=self)
2224

2325
def notify(self, plaintext, signature):
2426
try:
@@ -43,8 +45,8 @@ def notify(self, plaintext, signature):
4345
if plaintext.handle:
4446
message_json["message"]["handle"] = plaintext.handle
4547
self.ws.push(str(bleach.clean(json.dumps(message_json, indent=4), tags=ALLOWED_TAGS)))
46-
except Exception:
47-
pass
48+
except Exception as e:
49+
self.log.error('Market.Listener.notify Exception: %s' % e)
4850

4951

5052
class BroadcastListenerImpl(object):

market/tests/test_listeners.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,3 +74,11 @@ def test_MarketListeners_notify_with_handle_success(self):
7474
'test_avatar_hash',
7575
signature, False)
7676
self.ws.push.assert_called_with(self._create_valid_message_json('test_handle'))
77+
78+
def test_MarketListeners_save_message_exception(self):
79+
p = self._create_valid_plaintext_message('test_handle')
80+
signature = 'test_signature'
81+
l = MessageListenerImpl(self.ws, self.db)
82+
self.db.messages.save_message.side_effect = Exception("test_exception")
83+
l.notify(p, signature)
84+
self.assertEqual('[ERROR] Market.Listener.notify Exception: test_exception', self.catcher[0]['message'][0])

0 commit comments

Comments
 (0)