refactor: Add timeout to prep() function for offline messages

drwasho · cpacia · commit 73d558be4d5b · 2020-05-01T15:05:52.000-04:00
diff --git a/net/service/messagesender.go b/net/service/messagesender.go
@@ -111,8 +111,9 @@ func (ms *messageSender) prep() error {
 	if ms.s != nil {
 		return nil
 	}
-
-	nstr, err := ms.service.host.NewStream(ms.service.ctx, ms.p, ipfs.IPFSProtocolAppMainnetOne)
+	ctx, cancel := context.WithTimeout(ms.service.ctx, 3*time.Second)
+	defer cancel()
+	nstr, err := ms.service.host.NewStream(ctx, ms.p, ipfs.IPFSProtocolAppMainnetOne)
 	if err != nil {
 		return err
 	}

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,9 @@ func (ms *messageSender) prep() error {`
`111`	`111`	`if ms.s != nil {`
`112`	`112`	`return nil`
`113`	`113`	`}`
`114`		`-`
`115`		`- nstr, err := ms.service.host.NewStream(ms.service.ctx, ms.p, ipfs.IPFSProtocolAppMainnetOne)`
	`114`	`+ ctx, cancel := context.WithTimeout(ms.service.ctx, 3*time.Second)`
	`115`	`+ defer cancel()`
	`116`	`+ nstr, err := ms.service.host.NewStream(ctx, ms.p, ipfs.IPFSProtocolAppMainnetOne)`
`116`	`117`	`if err != nil {`
`117`	`118`	`return err`
`118`	`119`	`}`