[#1736] Express repo.Listing.CryptoDivisibility as exponential value

Author: placer14

repo/listing.go

@@ -577,6 +577,51 @@ func ExtractIDFromListing(data []byte) (*pb.ID, error) {
 	return vendorPlay, nil
 }
 
+// GetCryptoDivisibility returns the listing crypto divisibility
+func (l *Listing) GetCryptoDivisibility() uint32 {
+	ct, err := l.GetContractType()
+	if err == nil && ct != pb.Listing_Metadata_CRYPTOCURRENCY.String() {
+		return 0
+	}
+	div := parseProtoCryptoDivisibility(l.ListingBytes)
+	switch l.ListingVersion {
+	case 5:
+		return div
+	default: // version <4
+		if div != 0 {
+			return uint32(math.Log10(float64(div)))
+		}
+	}
+	return 0
+}
+
+func parseProtoCryptoDivisibility(listing []byte) uint32 {
+	var listingT struct {
+		Metadata struct {
+			CryptoDivisibility uint32 `json:"coinDivisibility"`
+		} `json:"metadata"`
+	}
+	err := json.Unmarshal(listing, &listingT)
+	if err != nil {
+		return 0
+	}
+	return listingT.Metadata.CryptoDivisibility
+}
+
+// GetCryptoCurrencyCode returns the listing crypto currency code
+func (l *Listing) GetCryptoCurrencyCode() string {
+	var listingT struct {
+		Metadata struct {
+			CryptoCurrencyCode string `json:"coinType"`
+		} `json:"metadata"`
+	}
+	err := json.Unmarshal(l.ListingBytes, &listingT)
+	if err != nil {
+		return ""
+	}
+	return listingT.Metadata.CryptoCurrencyCode
+}
+
 // GetTitle - return listing title
 func (l *Listing) GetTitle() (string, error) {
 	type title struct {
@@ -1301,6 +1346,8 @@ func (l *Listing) GetMetadata() (*pb.Listing_Metadata, error) {
 		Language:           lang,
 		EscrowTimeoutHours: l.GetEscrowTimeout(),
 		PriceModifier:      priceMod,
+		CryptoDivisibility: parseProtoCryptoDivisibility(l.ListingBytes),
+		CryptoCurrencyCode: l.GetCryptoCurrencyCode(),
 	}
 	return &m, nil
 }

repo/listing_test.go

@@ -38,6 +38,8 @@ func TestListingAttributes(t *testing.T) {
 		expectedSlug               string
 		expectedPrice              *repo.CurrencyValue
 		expectedAcceptedCurrencies []string
+		expectedCryptoDivisibility uint32
+		expectedCryptoCurrencyCode string
 	}{
 		{
 			fixtureName:      "v3-physical-good",
@@ -53,6 +55,8 @@ func TestListingAttributes(t *testing.T) {
 				},
 			},
 			expectedAcceptedCurrencies: []string{"BCH"},
+			expectedCryptoDivisibility: 0,
+			expectedCryptoCurrencyCode: "",
 		},
 		{
 			fixtureName:      "v4-physical-good",
@@ -68,6 +72,8 @@ func TestListingAttributes(t *testing.T) {
 				},
 			},
 			expectedAcceptedCurrencies: []string{"ZEC", "LTC", "BTC", "BCH"},
+			expectedCryptoDivisibility: 0,
+			expectedCryptoCurrencyCode: "",
 		},
 		{
 			fixtureName:      "v4-digital-good",
@@ -83,6 +89,8 @@ func TestListingAttributes(t *testing.T) {
 				},
 			},
 			expectedAcceptedCurrencies: []string{"ZEC"},
+			expectedCryptoDivisibility: 0,
+			expectedCryptoCurrencyCode: "",
 		},
 		{
 			fixtureName:      "v4-service",
@@ -98,6 +106,8 @@ func TestListingAttributes(t *testing.T) {
 				},
 			},
 			expectedAcceptedCurrencies: []string{"ZEC", "LTC", "BCH", "BTC"},
+			expectedCryptoDivisibility: 0,
+			expectedCryptoCurrencyCode: "",
 		},
 		{
 			fixtureName:                "v4-cryptocurrency",
@@ -106,6 +116,8 @@ func TestListingAttributes(t *testing.T) {
 			expectedSlug:               "ltc-xmr",
 			expectedPrice:              nil,
 			expectedAcceptedCurrencies: []string{"LTC"},
+			expectedCryptoDivisibility: 8,
+			expectedCryptoCurrencyCode: "XMR",
 		},
 		{
 			fixtureName:      "v5-physical-good",
@@ -121,10 +133,13 @@ func TestListingAttributes(t *testing.T) {
 				},
 			},
 			expectedAcceptedCurrencies: []string{"BTC", "BCH", "ZEC", "LTC", "ETH"},
+			expectedCryptoDivisibility: 0,
+			expectedCryptoCurrencyCode: "",
 		},
 	}
 
 	for _, e := range examples {
+		t.Logf("example listing (%s)", e.fixtureName)
 		var (
 			fixtureBytes = factory.MustLoadListingFixture(e.fixtureName)
 			l, err       = repo.UnmarshalJSONListing(fixtureBytes)
@@ -134,19 +149,25 @@ func TestListingAttributes(t *testing.T) {
 			continue
 		}
 		if l.Metadata.Version != e.expectedResponse {
-			t.Errorf("expected example (%s) to have version response (%+v), but instead was (%+v)", e.fixtureName, e.expectedResponse, l.Metadata.Version)
+			t.Errorf("expected to have version response (%+v), but instead was (%+v)", e.expectedResponse, l.Metadata.Version)
 		}
 		if title, _ := l.GetTitle(); title != e.expectedTitle {
-			t.Errorf("expected example (%s) to have title response (%+v), but instead was (%+v)", e.fixtureName, e.expectedTitle, title)
+			t.Errorf("expected to have title response (%+v), but instead was (%+v)", e.expectedTitle, title)
 		}
 		if slug, _ := l.GetSlug(); slug != e.expectedSlug {
-			t.Errorf("expected example (%s) to have slug response (%+v), but instead was (%+v)", e.fixtureName, e.expectedSlug, slug)
+			t.Errorf("expected to have slug response (%+v), but instead was (%+v)", e.expectedSlug, slug)
 		}
 		if price, _ := l.GetPrice(); !price.Equal(e.expectedPrice) {
-			t.Errorf("expected example (%s) to have price response (%+v), but instead was (%+v)", e.fixtureName, e.expectedPrice, price)
+			t.Errorf("expected to have price response (%+v), but instead was (%+v)", e.expectedPrice, price)
 		}
 		if acceptedCurrencies, _ := l.GetAcceptedCurrencies(); len(acceptedCurrencies) != len(e.expectedAcceptedCurrencies) {
-			t.Errorf("expected example (%s) to have acceptedCurrencies response (%+v), but instead was (%+v)", e.fixtureName, e.expectedAcceptedCurrencies, acceptedCurrencies)
+			t.Errorf("expected to have acceptedCurrencies response (%+v), but instead was (%+v)", e.expectedAcceptedCurrencies, acceptedCurrencies)
+		}
+		if actual := l.GetCryptoDivisibility(); actual != e.expectedCryptoDivisibility {
+			t.Errorf("expected to have divisibility (%d), but was (%d)", e.expectedCryptoDivisibility, actual)
+		}
+		if actual := l.GetCryptoCurrencyCode(); actual != e.expectedCryptoCurrencyCode {
+			t.Errorf("expected to have currency code (%s), but was (%s)", e.expectedCryptoCurrencyCode, actual)
 		}
 	}
 }