[#1983] Reserve wallet whitelist; ETH QA uses BTC reserve rater

Author: placer14

core/order.go

@@ -1707,28 +1707,39 @@ func quantityForItem(version uint32, item *pb.Order_Item) *big.Int {
 // ReserveCurrencyConverter will attempt to build a CurrencyConverter based on
 // the reserve currency, or will panic if unsuccessful
 func (n *OpenBazaarNode) ReserveCurrencyConverter() (*repo.CurrencyConverter, error) {
-	var reserveCode = "BTC"
-	if n.RegressionTestEnable || n.TestnetEnable {
-		reserveCode = "TBTC"
-	}
-
-	wal, err := n.Multiwallet.WalletForCurrencyCode(reserveCode)
-	if err != nil {
-		return nil, fmt.Errorf("unable to find reserve (%s) wallet", reserveCode)
-	}
+	// reserve currency whitelist
+	// TODO: later when the wallet can express whether it can
+	// provide reliable reserve currency rates, they can be
+	// reflected upon instead of using an explicit whitelist
+	var preferredReserveWalletCodes = []string{"BTC"}
+	for _, code := range preferredReserveWalletCodes {
+		var reserveCode = code
+		if n.RegressionTestEnable || n.TestnetEnable {
+			reserveCode = "T" + code
+		}
+
+		wal, err := n.Multiwallet.WalletForCurrencyCode(reserveCode)
+		if err != nil {
+			continue
+		}
 
-	if wal.ExchangeRates() == nil {
-		return nil, fmt.Errorf("reserve wallet has exchange rates disabled or unavailable")
-	}
+		if wal.ExchangeRates() == nil {
+			log.Warningf("%s reserve wallet has exchange rates disabled or unavailable", reserveCode)
+			continue
+		}
 
-	// priming the exchange rate cache
-	if _, err := wal.ExchangeRates().GetAllRates(false); err != nil {
-		log.Warningf("priming exchange rate cache: %s", err.Error())
-	}
+		if _, err := wal.ExchangeRates().GetAllRates(false); err != nil {
+			log.Warningf("%s reserve wallet priming exchange rate cache: %s", reserveCode, err.Error())
+			continue
+		}
 
-	cc, err := repo.NewCurrencyConverter(reserveCode, wal.ExchangeRates())
-	if err != nil {
-		return nil, fmt.Errorf("creating reserve currency converter: %s", err.Error())
+		cc, err := repo.NewCurrencyConverter(reserveCode, wal.ExchangeRates())
+		if err != nil {
+			log.Warningf("creating %s reserve currency converter: %s", reserveCode, err.Error())
+			continue
+		}
+		log.Infof("reserve exchange rates provided by %s wallet", reserveCode)
+		return cc, nil
 	}
-	return cc, nil
+	return nil, errors.New("unable to find reserve wallet with exchange rates")
 }

qa/test_framework/test_framework.py

@@ -82,15 +82,17 @@ def configure_node(self, n):
         config["Swarm"]["DisableNatPortMap"] = True
 
         self.cointype = self.cointype.upper()
-
         coinConfig = config["Wallets"][self.cointype]
+
         del config["Wallets"]
         config["Wallets"] = {}
-        config["Wallets"][self.cointype] = coinConfig
+        config["Wallets"]["BTC"] = coinConfig
+        config["Wallets"]["BTC"]["Type"] = "SPV"
+        config["Wallets"]["BTC"]["TrustedPeer"] = "127.0.0.1:18444"
+        config["Wallets"]["BTC"]["FeeAPI"] = ""
 
-        config["Wallets"][self.cointype]["Type"] = "SPV"
-        config["Wallets"][self.cointype]["TrustedPeer"] = "127.0.0.1:18444"
-        config["Wallets"][self.cointype]["FeeAPI"] = ""
+        if self.cointype != "BTC":
+            config["Wallets"][self.cointype] = coinConfig
 
         with open(os.path.join(dir_path, "config"), 'w') as outfile:
             outfile.write(json.dumps(config, indent=4))

repo/currency_converter.go

@@ -42,7 +42,7 @@ func NewCurrencyConverter(reserveCode string, rater rater) (*CurrencyConverter,
 	if rate, err := cc.getExchangeRate(cc.reserveCode); err != nil {
 		return nil, fmt.Errorf("unable to get reserve rate (%s): %s", cc.reserveCode, err.Error())
 	} else if rate != 1.0 {
-		return nil, fmt.Errorf("research exchange rate was not 1.0 (%f)", rate)
+		return nil, fmt.Errorf("reserve exchange rate was not 1.0 (%f)", rate)
 	}
 	return cc, nil
 }