Merge pull request #1940 from OpenBazaar/1681-escrowrelease-without-inputs

placer14 · web-flow · commit f9c7d3fa33e4 · 2020-01-04T00:40:18.000-05:00
[#1681] Protect POSTReleaseEscrow sweep when there are no inputs
diff --git a/core/completion.go b/core/completion.go
@@ -349,6 +349,10 @@ func (n *OpenBazaarNode) ReleaseFundsAfterTimeout(contract *pb.RicardianContract
 		}
 	}
 
+	if len(txInputs) == 0 {
+		return errors.New("there are no inputs available for this transaction")
+	}
+
 	chaincode, err := hex.DecodeString(contract.BuyerOrder.Payment.Chaincode)
 	if err != nil {
 		return err

Original file line number	Diff line number	Diff line change
`@@ -349,6 +349,10 @@ func (n OpenBazaarNode) ReleaseFundsAfterTimeout(contract pb.RicardianContract`
`349`	`349`	`}`
`350`	`350`	`}`
`351`	`351`
	`352`	`+ if len(txInputs) == 0 {`
	`353`	`+ return errors.New("there are no inputs available for this transaction")`
	`354`	`+ }`
	`355`	`+`
`352`	`356`	`chaincode, err := hex.DecodeString(contract.BuyerOrder.Payment.Chaincode)`
`353`	`357`	`if err != nil {`
`354`	`358`	`return err`