Merge pull request #1360 from mikeschen/error-responses

update response messages and error codes

Author: mikeschen

src/app/api/mobile/refreshToken/route.ts

@@ -18,7 +18,10 @@ async function postHandler (request: NextRequest): Promise<any> {
       throw new Error('Invalid payload')
     }
   } catch (error) {
-    return NextResponse.json({ error: 'Unexpected error', status: 400 })
+    return NextResponse.json(
+      { error },
+      { status: 400 }
+    )
   }
 
   let response: Auth0.JSONApiResponse<Auth0.TokenSet> | undefined

src/app/api/user/bulkImportTicks/route.ts

@@ -113,7 +113,10 @@ const postHandler = async (req: NextRequest): Promise<any> => {
 
   if (uuid == null || profileUrl == null || auth0Userid == null) {
     // A bug in our code - shouldn't get here.
-    return NextResponse.json({ status: 500 })
+    return NextResponse.json(
+      { error: 'Internal Server Error' },
+      { status: 500 }
+    )
   }
 
   // fetch data from mountain project here

src/app/api/user/get-signed-url/route.ts

@@ -17,14 +17,20 @@ const getHanlder = async (req: NextRequest): Promise<any> => {
   try {
     const fullFilename = prepareFilenameFromRequest(req)
     if (fullFilename == null) {
-      return NextResponse.json({ status: 400 })
+      return NextResponse.json(
+        { error: 'Bad Request - Missing filename parameter' },
+        { status: 400 }
+      )
     }
     const url = await getSignedUrlForUpload(fullFilename)
 
     return NextResponse.json({ url, fullFilename: '/' + fullFilename })
   } catch (e) {
     console.error('Uploading to media server failed', e)
-    return NextResponse.json({ status: 500 })
+    return NextResponse.json(
+      { error: 'Internal Server Error - Failed to generate signed URL' },
+      { status: 500 }
+    )
   }
 }
 

src/app/api/user/me/route.ts

@@ -10,7 +10,10 @@ const getHandler = async (req: NextRequest): Promise<any> => {
   const accessToken = req.headers.get(PREDEFINED_HEADERS.access_token)
 
   if (accessToken == null || uuid == null) {
-    return NextResponse.json({ status: 500 })
+    return NextResponse.json(
+      { error: 'Internal Server Error' },
+      { status: 500 }
+    )
   }
 
   try {

src/app/api/user/remove-media/route.ts

@@ -11,13 +11,22 @@ const postHandler = async (req: NextRequest): Promise<any> => {
   try {
     const filename = getBucketPathFromRequest(req)
     if (filename == null) {
-      return NextResponse.json({ status: 400 })
+      return NextResponse.json(
+        { error: 'Bad Request - Missing filename parameter' },
+        { status: 400 }
+      )
     }
     await deleteMediaFromBucket(filename)
-    return NextResponse.json({ status: 200 })
+    return NextResponse.json(
+      { message: 'Media file deleted successfully' },
+      { status: 200 }
+    )
   } catch (e) {
     console.log('Removing file from media server failed', e)
-    return NextResponse.json({ status: 500 })
+    return NextResponse.json(
+      { error: 'Internal Server Error - Failed to delete media file' },
+      { status: 500 }
+    )
   }
 }
 

src/js/auth/withUserAuth.ts

@@ -18,7 +18,10 @@ export const withUserAuth = (handler: Next13APIHandler): Next13APIHandler => {
       req.headers.set(PREDEFINED_HEADERS.access_token, session.accessToken)
       return await handler(req)
     } else {
-      return NextResponse.json({ status: 401 })
+      return NextResponse.json(
+        { error: 'Unauthorized - Authentication required' },
+        { status: 401 }
+      )
     }
   }
 }