fix final 3ds build failures

Author: Totto16

src/helper/console_helpers.cpp

@@ -10,6 +10,7 @@
 #include <switch.h>
 #elif defined(__3DS__)
 #include <3ds.h>
+#include <cstdlib>
 #endif
 
 #include <fmt/format.h>
@@ -30,12 +31,12 @@ void console::debug_write(const char* text, size_t size) {
 #if defined(__3DS__)
     const auto size = url.size() >= 0x100 ? url.size() + 1 : 0x100;
 
-    char* buffer = malloc(size);
+    char* buffer = reinterpret_cast<char*>(malloc(size));
 
     memcpy(buffer, url.c_str(), url.size());
     buffer[url.size()] = '\0';
 
-    aptLaunchLibraryApplet(APPID_WEB, buffer, IN_OUT_BUF_SIZE, 0);
+    aptLaunchLibraryApplet(APPID_WEB, buffer, size, 0);
 
     const auto result = std::string{ buffer };
 

src/platform/capabilities.cpp

@@ -75,16 +75,16 @@ namespace {
     //TODO: this is dangerous, if we supply user input, so use SDL_OpenURL preferably
 
 #if defined(WIN32) || defined(_WIN32) || defined(__WIN32__) || defined(__NT__)
-    const std::string shellCommand = "start " + url;
+    const std::string shell_command = "start " + url;
 #elif defined(__APPLE__)
-    const std::string shellCommand = "open " + url;
+    const std::string shell_command = "open " + url;
 #elif defined(__linux__)
-    const std::string shellCommand = "xdg-open " + url;
+    const std::string shell_command = "xdg-open " + url;
 #else
 #error "Unsupported platform"
 #endif
 
-    const auto result = system(shellCommand.c_str());
+    const auto result = system(shell_command.c_str());
     if (result < 0) {
         spdlog::error("Error in opening url: {}", get_error_from_errno());
         return false;

src/platform/capabilities.hpp

@@ -53,7 +53,7 @@ namespace utils {
                 {static_cast<u8>(CrossPlatformAction::OPEN_SETTINGS), { 0 }},
                 {          static_cast<u8>(CrossPlatformAction::TAB), { 0 }}
     };
-#elif defined(__CONSOLE__)
+#elif defined(__SWITCH__)
             {
                 {           static_cast<u8>(CrossPlatformAction::OK),{ JOYCON_A }                                                                     },
                 {        static_cast<u8>(CrossPlatformAction::PAUSE),                                       { JOYCON_PLUS }},
@@ -70,6 +70,7 @@ namespace utils {
                 {static_cast<u8>(CrossPlatformAction::OPEN_SETTINGS),                                          { JOYCON_Y }},
                 {          static_cast<u8>(CrossPlatformAction::TAB),                                                    {}}, // no tab support
 };
+//TODO: support 3ds
 #else
             {
                 {           static_cast<u8>(CrossPlatformAction::OK), { SDLK_RETURN, SDLK_SPACE }},

src/platform/console_input.cpp

@@ -74,11 +74,12 @@ helper::optional<InputEvent> JoystickInput::sdl_event_to_input_event(const SDL_E
 }
 #elif defined(__3DS__)
 
+//TODO: implement for 3ds
 helper::optional<InputEvent> JoystickInput::sdl_event_to_input_event(const SDL_Event& event) const {
+    UNUSED(event);
     return helper::nullopt;
 }
 
-//TODO: implement for 3ds
 #endif