fix clang-tidy errors

Author: Totto16

src/helper/color.hpp

@@ -131,22 +131,22 @@ struct Color {
         const auto s = static_cast<FloatType>(color.s);
         const auto v = static_cast<FloatType>(color.v);
 
-        FloatType chroma = v * s;
+        const FloatType chroma = v * s;
 
         FloatType hue = h;
         if (hue >= static_cast<FloatType>(360.0)) {
             hue = static_cast<FloatType>(0.0);
         }
 
 
-        FloatType x = chroma
-                      * (static_cast<FloatType>(1.0)
-                         - fabs_constexpr(
-                                 fmod_constexpr(hue / static_cast<FloatType>(60.0), static_cast<FloatType>(2.0))
-                                 - static_cast<FloatType>(1.0)
-                         ));
+        const FloatType x = chroma
+                            * (static_cast<FloatType>(1.0)
+                               - fabs_constexpr(
+                                       fmod_constexpr(hue / static_cast<FloatType>(60.0), static_cast<FloatType>(2.0))
+                                       - static_cast<FloatType>(1.0)
+                               ));
 
-        u64 index = static_cast<u64>(hue / static_cast<FloatType>(60.0));
+        const u64 index = static_cast<u64>(hue / static_cast<FloatType>(60.0));
 
         FloatType d_r{};
         FloatType d_g{};
@@ -188,7 +188,7 @@ struct Color {
         }
 
 
-        FloatType m = v - chroma;
+        const FloatType m = v - chroma;
 
         const auto finish_value = [m](FloatType value) -> u8 {
             const auto result =

src/helper/color_literals.hpp

@@ -597,7 +597,9 @@ static_assert("rgb(0xAB, 0xCD, 0xEF)"_c == "rgb(171, 205, 239)"_c);
 static_assert("hsv(0, 0, 0.79)"_c == "#C9C9C9"_c);
 
 
-// due to an error in MSVC, the "#FFFFFF"_c literal, can't be constants, so juts using the runtime variant (which has a optional access without check, but the CI detects errors in those strings on other platforms and compilers at compiler time, so that's not that bad)
+// due to an error in MSVC, the "#FFFFFF"_c literal, can't be constants, so juts using the runtime variant
+// (which has a optional access without check, but the CI detects errors in those strings on other platforms and compilers at compiler time,
+// so that's not that bad)
 #if defined(_MSC_VER)
 #define COLOR_LITERAL(color_string) Color::from_string(color_string).value() //NOLINT(cppcoreguidelines-macro-usage)
 #else

tests/core/color.cpp

@@ -1,8 +1,6 @@
 
 #include "helper/color.hpp"
 
-
-#include "gtest/gtest.h"
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 #include <string>
@@ -212,7 +210,7 @@ TEST(HSVColor, InvalidConstructors) {
 #endif
 
 
-TEST(ColorConversion, HSV_to_RGB_to_HSV) {
+TEST(ColorConversion, HSV_to_RGB_to_HSV) { //NOLINT(readability-function-cognitive-complexity)
 
 #if COLOR_TEST_MODE == 0
     const std::vector<HSVColor> colors{
@@ -258,7 +256,7 @@ TEST(ColorConversion, HSV_to_RGB_to_HSV) {
 }
 
 
-TEST(ColorConversion, RGG_to_HSV_to_RGB) {
+TEST(ColorConversion, RGG_to_HSV_to_RGB) { //NOLINT(readability-function-cognitive-complexity)
 
 #if COLOR_TEST_MODE == 0
     const std::vector<Color> colors{