fix: explicitly move all bool helper values, instead of copying unnecessary

Author: Totto16

src/libs/core/helper/bool_wrapper.hpp

@@ -20,6 +20,19 @@ namespace helper {
 
         BoolWrapper(bool value, const std::optional<T>& additional) : m_value{ value }, m_additional{ additional } { }
 
+        BoolWrapper(const BoolWrapper& other) = delete;
+
+        BoolWrapper& operator=(const BoolWrapper& other) = delete;
+
+        BoolWrapper(BoolWrapper&& other) noexcept
+            : m_value{ other.m_value },
+              m_additional{ std::move(other.m_additional) } {
+            other.m_value = false;
+            other.m_additional = std::nullopt;
+        }
+
+        BoolWrapper& operator=(BoolWrapper&& other) noexcept = default;
+
         const std::optional<T>& get_additional() const {
             return m_additional;
         }

src/scenes/recording_selector/recording_chooser.cpp

@@ -101,7 +101,7 @@ ui::Widget::EventHandleResult custom_ui::RecordingFileChooser::handle_event(
 ) {
     //TODO(Totto): this double nested component can't correctly detect focus changes (since the checking for a focus change only occurs at one level deep)
     //TODO(Totto): allow horizontal RIGHT <-> LEFT focus change on horizontal focus_layouts
-    if (const auto handled = m_main_grid.handle_event(input_manager, event); handled) {
+    if (auto handled = m_main_grid.handle_event(input_manager, event); handled) {
         return handled;
     }
 

src/scenes/settings_menu/color_setting_row.cpp

@@ -179,7 +179,7 @@ ui::Widget::EventHandleResult custom_ui::ColorSettingRow::handle_event(
         const std::shared_ptr<input::InputManager>& input_manager,
         const SDL_Event& event
 ) {
-    const auto result = m_main_layout.handle_event(input_manager, event);
+    auto result = m_main_layout.handle_event(input_manager, event);
     if (const auto additional = result.get_additional(); additional.has_value()) {
         if (std::get<0>(additional.value()) == ui::EventHandleType::RequestAction) {
             return {

src/ui/layouts/focus_layout.cpp

@@ -70,7 +70,7 @@ ui::Widget::EventHandleResult ui::FocusLayout::handle_focus_change_button_events
         const SDL_Event& event
 ) {
 
-    Widget::EventHandleResult handled = false;
+    ui::Widget::EventHandleResult handled = false;
 
     const auto navigation_action = input_manager->get_navigation_event(event);
 
@@ -96,7 +96,7 @@ ui::Widget::EventHandleResult ui::FocusLayout::handle_focus_change_events(
         return false;
     }
 
-    Widget::EventHandleResult handled = false;
+    ui::Widget::EventHandleResult handled{ false };
 
     if (m_focus_id.has_value()) {
         const auto& widget = m_widgets.at(focusable_index_by_id(m_focus_id.value()));

src/ui/layouts/scroll_layout.cpp

@@ -240,7 +240,7 @@ ui::Widget::EventHandleResult ui::ScrollLayout::handle_focus_change_events(
         return false;
     }
 
-    Widget::EventHandleResult handled = false;
+    Widget::EventHandleResult handled{ false };
 
 
     if (m_focus_id.has_value()) {