Skip to content

Commit 31f8e58

Browse files
committed
fix(build): remove now unnecessary emsdk patches
- since upstream emscripten-core/emscripten#23094 was merged, the local patch is now unnecessary - fix the rest to incorporate these changes
1 parent bd4e797 commit 31f8e58

File tree

4 files changed

+3
-119
lines changed

4 files changed

+3
-119
lines changed

platforms/build-web.sh

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,10 @@ PATCH_DIR="platforms/emscripten"
2323

2424
if ! [ -e "$EMSCRIPTEN_PACTH_FILE" ]; then
2525
##TODO: upstream those patches
26-
# see: https://github.com/emscripten-core/emscripten/pull/18379/commits
27-
# and: https://github.com/emscripten-core/emscripten/pull/18379
26+
# see: https://github.com/emscripten-core/emscripten/pull/18379
2827
# and: https://github.com/emscripten-core/emscripten/pull/22946
2928

3029
git apply --unsafe-paths -p1 --directory="$EMSCRIPTEN_UPSTREAM_ROOT" "$PATCH_DIR/sdl2_image_port.diff"
31-
git apply --unsafe-paths -p1 --directory="$EMSCRIPTEN_UPSTREAM_ROOT" "$PATCH_DIR/sdl2_mixer_port.diff"
32-
git apply --unsafe-paths -p1 --directory="$EMSCRIPTEN_UPSTREAM_ROOT" "$PATCH_DIR/default_settings.diff"
3330

3431
touch "$EMSCRIPTEN_PACTH_FILE"
3532
fi
@@ -40,7 +37,7 @@ fi
4037
EMSDK_QUIET=1 source "$EMSCRIPTEN_ROOT/emsdk_env.sh" >/dev/null
4138

4239
## build theneeded dependencies
43-
embuilder build sdl2-mt harfbuzz-mt freetype zlib sdl2_ttf mpg123 "sdl2_mixer:formats=mp3" libpng-mt "sdl2_image:formats=png,svg:mt=1" icu-mt
40+
embuilder build sdl2-mt harfbuzz-mt freetype zlib sdl2_ttf mpg123 "sdl2_mixer-mp3-mt" libpng-mt "sdl2_image:formats=png,svg:mt=1" icu-mt
4441

4542
export EMSCRIPTEN_SYS_ROOT="$EMSCRIPTEN_UPSTREAM_ROOT/cache/sysroot"
4643

platforms/emscripten/default_settings.diff

Lines changed: 0 additions & 13 deletions
This file was deleted.

platforms/emscripten/sdl2_mixer_port.diff

Lines changed: 0 additions & 100 deletions
This file was deleted.

tools/dependencies/meson.build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ if meson.is_cross_build()
6060
['SDL2-mt', 'SDL2'],
6161
['SDL2_ttf'],
6262
['mpg123'],
63-
['SDL2_mixer_mp3', 'SDL2_mixer'],
63+
['SDL2_mixer-mp3-mt', 'SDL2_mixer'],
6464
['SDL2_image-png-svg-mt', 'SDL2_image'],
6565
['icu_common-mt', 'icu-uc'],
6666
]

0 commit comments

Comments
 (0)